You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/09/19 18:49:08 UTC
svn commit: r1881856 - in /pdfbox/trunk/pdfbox/src:
main/java/org/apache/pdfbox/pdmodel/
main/java/org/apache/pdfbox/pdmodel/encryption/
test/java/org/apache/pdfbox/encryption/
Author: tilman
Date: Sat Sep 19 18:49:08 2020
New Revision: 1881856
URL: http://svn.apache.org/viewvc?rev=1881856&view=rev
Log:
PDFBOX-4421: Sonar fix: remove usage of generic wildcard type
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PDEncryption.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestPublicKeyEncryption.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java?rev=1881856&r1=1881855&r2=1881856&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java Sat Sep 19 18:49:08 2020
@@ -1166,7 +1166,7 @@ public class PDDocument implements Close
encryption = new PDEncryption();
}
- SecurityHandler<? extends ProtectionPolicy> securityHandler =
+ SecurityHandler<ProtectionPolicy> securityHandler =
SecurityHandlerFactory.INSTANCE.newSecurityHandlerForPolicy(policy);
if (securityHandler == null)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PDEncryption.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PDEncryption.java?rev=1881856&r1=1881855&r2=1881856&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PDEncryption.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PDEncryption.java Sat Sep 19 18:49:08 2020
@@ -77,7 +77,7 @@ public class PDEncryption implements COS
public static final int DEFAULT_VERSION = VERSION0_UNDOCUMENTED_UNSUPPORTED;
private final COSDictionary dictionary;
- private SecurityHandler<? extends ProtectionPolicy> securityHandler;
+ private SecurityHandler<ProtectionPolicy> securityHandler;
/**
* creates a new empty encryption dictionary.
@@ -102,7 +102,7 @@ public class PDEncryption implements COS
* @return a security handler instance
* @throws IOException if there is no security handler available which matches the Filter
*/
- public SecurityHandler<? extends ProtectionPolicy> getSecurityHandler() throws IOException
+ public SecurityHandler<ProtectionPolicy> getSecurityHandler() throws IOException
{
if (securityHandler == null)
{
@@ -115,7 +115,7 @@ public class PDEncryption implements COS
* Sets the security handler used in this encryption dictionary
* @param securityHandler new security handler
*/
- public void setSecurityHandler(SecurityHandler<? extends ProtectionPolicy> securityHandler)
+ public void setSecurityHandler(SecurityHandler<ProtectionPolicy> securityHandler)
{
this.securityHandler = securityHandler;
// TODO set Filter (currently this is done by the security handlers)
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java?rev=1881856&r1=1881855&r2=1881856&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java Sat Sep 19 18:49:08 2020
@@ -81,7 +81,7 @@ public final class SecurityHandlerFactor
* @param policy the protection policy for which to create a security handler
* @return a new SecurityHandler instance, or null if none is available
*/
- public SecurityHandler<? extends ProtectionPolicy> newSecurityHandlerForPolicy(ProtectionPolicy policy)
+ public SecurityHandler<ProtectionPolicy> newSecurityHandlerForPolicy(ProtectionPolicy policy)
{
Class<? extends SecurityHandler> handlerClass = policyToHandler.get(policy.getClass());
if (handlerClass == null)
@@ -99,7 +99,7 @@ public final class SecurityHandlerFactor
* @param name the Filter name from the PDF encryption dictionary
* @return a new SecurityHandler instance, or null if none is available
*/
- public SecurityHandler<? extends ProtectionPolicy> newSecurityHandlerForFilter(String name)
+ public SecurityHandler<ProtectionPolicy> newSecurityHandlerForFilter(String name)
{
Class<? extends SecurityHandler> handlerClass = nameToHandler.get(name);
if (handlerClass == null)
@@ -119,7 +119,7 @@ public final class SecurityHandlerFactor
* @param args array of objects to be passed as arguments to the constructor call.
* @return a new SecurityHandler instance, or null if none is available.
*/
- private SecurityHandler<? extends ProtectionPolicy> newSecurityHandler(Class<? extends SecurityHandler> handlerClass,
+ private SecurityHandler<ProtectionPolicy> newSecurityHandler(Class<? extends SecurityHandler> handlerClass,
Class<?>[] argsClasses, Object[] args)
{
try
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestPublicKeyEncryption.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestPublicKeyEncryption.java?rev=1881856&r1=1881855&r2=1881856&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestPublicKeyEncryption.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestPublicKeyEncryption.java Sat Sep 19 18:49:08 2020
@@ -339,7 +339,8 @@ public class TestPublicKeyEncryption
TestPublicKeyEncryption.class.getResourceAsStream("PDFBOX-4421-keystore.pfx"),
"testnutzer"))
{
- Assert.assertTrue(doc.getEncryption().getSecurityHandler() instanceof PublicKeySecurityHandler);
+ Assert.assertEquals("PublicKeySecurityHandler",
+ doc.getEncryption().getSecurityHandler().getClass().getSimpleName());
Assert.assertEquals(128, doc.getEncryption().getSecurityHandler().getKeyLength());
PDFTextStripper stripper = new PDFTextStripper();
//Assert.assertEquals("Key length: 128", stripper.getText(doc).trim())
@@ -363,7 +364,8 @@ public class TestPublicKeyEncryption
TestPublicKeyEncryption.class.getResourceAsStream("PDFBOX-4421-keystore.pfx"),
"testnutzer"))
{
- Assert.assertTrue(doc.getEncryption().getSecurityHandler() instanceof PublicKeySecurityHandler);
+ Assert.assertEquals("PublicKeySecurityHandler",
+ doc.getEncryption().getSecurityHandler().getClass().getSimpleName());
Assert.assertEquals(256, doc.getEncryption().getSecurityHandler().getKeyLength());
PDFTextStripper stripper = new PDFTextStripper();
//Assert.assertEquals("Key length: 256", stripper.getText(doc).trim())