[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions
URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309502340
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java
 ##########
 @@ -60,6 +60,17 @@
    */
   Set<Expr> getArrayInputs(List<Expr> args);
 
+  /**
+   * Returns true if apply function produces an array output
+   */
+  default boolean hasArrayOutput()
+  {
+    return false;
 
 Review comment:
   This should not be allowed imo, but I think we'll have to discuss this further when we get around to adding full type inference to the expression system. I will adjust the javadoc to state it should not be done currently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org