You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "xiaobiaozhao (via GitHub)" <gi...@apache.org> on 2023/05/05 14:24:14 UTC

[GitHub] [incubator-kvrocks] xiaobiaozhao commented on pull request #1418: support sync migration

xiaobiaozhao commented on PR #1418:
URL: https://github.com/apache/incubator-kvrocks/pull/1418#issuecomment-1536341427

   > @ellutionist Thanks for your explanation.
   > 
   > I have not dived into these changes deeply, but if you just want to make lifetime of SyncMigrateContext as long as the command object, you can store an instance of SyncMigrateContext in CommandClusterX directly (`class CommandClusterX { SyncMigrateContext ctx_; ... }`), and pass some non-owning pointer (like raw pointer, no ownership) to the migrator.
   
   I agree with that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org