[jira] [Commented] (PHOENIX-2434) CSV loader: fail on invalid booleans

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013384#comment-15013384 ] 

Hadoop QA commented on PHOENIX-2434:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12773219/PHOENIX-2434.patch
  against master branch at commit 8d41ab0b4d70969b59136cce01ef71c6b8c754f8.
  ATTACHMENT ID: 12773219

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 32 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        CSVRecord csvRecordWithTooManyFields = createCsvRecord("123,NameValue,42,1:2:3,true,Garbage");
+        CSVRecord csvRecordWithInvalidType = createCsvRecord("123,NameValue,ThisIsNotANumber,1:2:3,true");

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/178//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/178//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/178//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/178//console

This message is automatically generated.

> CSV loader: fail on invalid booleans
> ------------------------------------
>
>                 Key: PHOENIX-2434
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2434
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Bruno Dumon
>         Attachments: PHOENIX-2434.patch
>
>
> Currently the CSV loader parses boolean values using Boolean.parseBoolean(), indirectly via PBoolean.toObject(String). This recognizes the string "true" (ignoring case) as true, anything else is false.
> This is not very friendly to the user, who might for example think that '1' is true and '0' is false. It would be better to fail on invalid input, just like is the case for invalid numbers or invalid dates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)