You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2017/01/31 21:47:12 UTC
kudu git commit: Make delete_table-test less flaky
Repository: kudu
Updated Branches:
refs/heads/master f994ee96c -> 89b703995
Make delete_table-test less flaky
Add AssertEventually to this DeleteTablet() call so it doesn't race
against the completion of the tablet creation process.
Change-Id: Idaa6bc8fb760351e9ecd8c39ef93c59559ce62f8
Reviewed-on: http://gerrit.cloudera.org:8080/5830
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/89b70399
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/89b70399
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/89b70399
Branch: refs/heads/master
Commit: 89b703995d11d6cf58e0489fd9f372679715636c
Parents: f994ee9
Author: Mike Percy <mp...@apache.org>
Authored: Mon Jan 30 18:30:11 2017 -0800
Committer: Mike Percy <mp...@apache.org>
Committed: Tue Jan 31 21:47:00 2017 +0000
----------------------------------------------------------------------
src/kudu/integration-tests/delete_table-test.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/89b70399/src/kudu/integration-tests/delete_table-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/delete_table-test.cc b/src/kudu/integration-tests/delete_table-test.cc
index 15114a3..eae3eac 100644
--- a/src/kudu/integration-tests/delete_table-test.cc
+++ b/src/kudu/integration-tests/delete_table-test.cc
@@ -1010,8 +1010,10 @@ TEST_F(DeleteTableTest, TestWebPageForTombstonedTablet) {
// Tombstone the tablet.
ExternalTabletServer* ets = cluster_->tablet_server(0);
- ASSERT_OK(itest::DeleteTablet(ts_map_[ets->uuid()],
- tablet_id, TABLET_DATA_TOMBSTONED, boost::none, timeout));
+ AssertEventually([&]() {
+ ASSERT_OK(itest::DeleteTablet(ts_map_[ets->uuid()],
+ tablet_id, TABLET_DATA_TOMBSTONED, boost::none, timeout));
+ });
// Check the various web pages associated with the tablet, ensuring
// they don't crash and at least have the tablet ID within them.