You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/11/21 16:24:58 UTC

[jira] [Commented] (QPID-7537) Improve implementations of equal methods in various classes to be able to account for sub-classes

    [ https://issues.apache.org/jira/browse/QPID-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684000#comment-15684000 ] 

ASF subversion and git services commented on QPID-7537:
-------------------------------------------------------

Commit 1770717 from orudyy@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1770717 ]

QPID-7537: Improve implementations of equal methods in various classes to be able to account for sub-classes

> Improve implementations of equal methods in various classes to be able to account for sub-classes
> -------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7537
>                 URL: https://issues.apache.org/jira/browse/QPID-7537
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client, Java Common, Java Performance Tests
>            Reporter: Alex Rudyy
>             Fix For: qpid-java-6.2
>
>
> The equals method of the following classes break symmetry if the passed in object is a subclass. Use  this.getClass() instead of instanceof. 
> * BindingImpl
> * QpidSslRMIServerSocketFactory
> * HeadersBinding
> * AMQPProtocolVersionWrapper
> * UsernamePrincipal 
> * GroupPrincipal
> * Action
> * Rule
> * InetNetwork
> * AMQBrokerDetails
> * AMQDestination
> * AMQQueue
> * AMQTopic
> * XidImpl 
> * FieldTable
> * ProtocolInitiation
> * QpidRAConnectionRequestInfo
> * QpidRAManagedConnectionFactory 
> * QpidRAMessage 
> * QpidResourceAdapter
> * ListPropertyValue 
> * NumericGeneratedPropertySupport
> * RangePropertyValue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org