[GitHub] [beam] kennknowles commented on a diff in pull request #26263: Add Gradle sub-projects to enable parallel running of Kafka tests (#2…

["kennknowles (via GitHub)" <gi...@apache.org>]

kennknowles commented on code in PR #26263:
URL: https://github.com/apache/beam/pull/26263#discussion_r1173859773


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/kafka/KafkaTestUtilities.groovy:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.gradle.kafka
+
+import org.gradle.api.Project
+import org.gradle.api.artifacts.ConfigurationContainer
+import org.gradle.api.tasks.testing.Test
+
+import javax.inject.Inject
+
+class KafkaTestUtilities {
+  abstract static class KafkaBatchIT extends Test {
+
+    @Inject

Review Comment:
   I'm not familiar with this. Can you document the control/data flow? I'm assuming the idea is that we get default values for most things and can tweak them via passing parameters in a particular way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org