[jira] [Commented] (CASSANDRA-14417) nodetool import cleanup/fixes

["Jordan West (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475273#comment-16475273 ] 

Jordan West commented on CASSANDRA-14417:
-----------------------------------------

All minor comments:
 * Deprecated {{CFS#loadNewSSTables()}} no longer needs to be synchronized. It just constructs an {{ImportOptions}} instance and passes it to the synchronized {{loadNewSSTables(ImportOptions).}}
 * Add a reference (e.g. @see) to {{CFSMBean.importNewSSTables}} from {{SSMBean.loadNewSSTables}}
 * In Verifier, is it more appropriate to favor {{OutputHandler#output}} over {{OutputHandler#debug}} for the error message when a key is out of range?
 * Would like to see some tests (including base/empty case, edge cases like wrap around) for {{RangeOwnHelper}}
 * {{nodetool refresh}}: Is the removal of the deprecation output intentional?

> nodetool import cleanup/fixes
> -----------------------------
>
>                 Key: CASSANDRA-14417
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14417
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Major
>             Fix For: 4.x
>
>
> * We shouldn't expose importNewSSTables in both StorageServiceMBean and CFSMbean
> * Allow a quicker token check without doing an extended verify
> * Introduce an ImportOptions class to avoid passing in 100 booleans in importNewSSTables



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org