[GitHub] [beam] aaltay commented on a change in pull request #15124: Skip BQ tests if no BQ client is installed

[GitBox <gi...@apache.org>]

aaltay commented on a change in pull request #15124:
URL: https://github.com/apache/beam/pull/15124#discussion_r663296918



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -77,14 +77,18 @@
 # pylint: disable=wrong-import-order, wrong-import-position
 try:
   from apitools.base.py.exceptions import HttpError
+  from google.cloud import bigquery as gcp_bigquery
 except ImportError:
+  gcp_bigquery = None
   HttpError = None
 # pylint: enable=wrong-import-order, wrong-import-position
 
 _LOGGER = logging.getLogger(__name__)
 
 
-@unittest.skipIf(HttpError is None, 'GCP dependencies are not installed')
+@unittest.skipIf(
+    HttpError is None or gcp_bigquery is None,

Review comment:
       Why do we need apitools and gcp_bigquery at the same time? (Are not they 2 mutually exclusive clients?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org