You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/04/22 11:54:21 UTC
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18442
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
IMPALA-10111: Improve TestWebPage::test_query_stmt logging
TestWebPage::test_query_stmt is flaky, to better understand the root
cause of this test failure this commit adds the web page JSON result
to the error message.
Testing:
- Executed the test locally.
Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
---
M tests/webserver/test_web_pages.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/18442/1
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
Patch Set 1:
Thank you for the review Wenzhe!
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 20:41:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 01:04:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8060/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 20:40:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 17:00:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10480/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Apr 2022 12:14:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10111: Improve TestWebPage::test query stmt logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18442 )
Change subject: IMPALA-10111: Improve TestWebPage::test_query_stmt logging
......................................................................
IMPALA-10111: Improve TestWebPage::test_query_stmt logging
TestWebPage::test_query_stmt is flaky, to better understand the root
cause of this test failure this commit adds the web page JSON result
to the error message.
Testing:
- Executed the test locally.
Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Reviewed-on: http://gerrit.cloudera.org:8080/18442
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
Gerrit-Change-Number: 18442
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>