You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/01 18:10:17 UTC

[GitHub] [airflow] davlum edited a comment on issue #6196: [AIRFLOW-3152] Kubernetes Pod Operator should support init containers.

davlum edited a comment on issue #6196: [AIRFLOW-3152] Kubernetes Pod Operator should support init containers.
URL: https://github.com/apache/airflow/pull/6196#issuecomment-537159729
 
 
   I would suggest instead of implementing a custom object (`InitContainer`) that you allow users to pass the the`kubernetes.client.models.V1Container` object directly. Your `InitContainer` only implements a small portion of the full `kubernetes.client.models.V1Container`and requires additional code to marshal to the appropriate object. This should lower the complexity and increase the functionality of this PR significantly. The old Airflow Kubernetes objects are only there for backwards compatibility API reasons.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services