You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Felix Knecht <fe...@otego.com> on 2011/02/24 17:27:28 UTC

Where to put the parent/pom.xml

Hi all

There exists ATM both alternatives about the location of the parent 
pom.xml (see also [1])

"About the parent poms:
1.- some projects use the root/pom.xml as parent (james server project 
does that)
2. others create a root/parent/pom.xml specific project." [2]

e.g.
- james/server uses 1.
- james/imap uses 2.

I think it would be easier to understand for project newbies (like me) 
if this could be harmonized to use either 1. or 2.

Regarding maven-site-plugin used for site generation it's much easier to 
use 1. because this way the site(s) can be generated as multi-module.
IMO it's also easier to read when just having a single parent pom than 
having (for the same project) a grandparent pom, referenced by a parent 
pom, in which we build the children (<modules>) which reference the 
grandparent pom as parent pom (2.). Sounds weird, doesn't it ;-)?

When now deploying e.g. the generated site of james/imap first the site 
of the (grand)parent is deployed to {url} and afterwards it gets 
overridden by the root (parent), which is deployed to the same {url}

I'd like to open the discussion about either switching all james 
projects to 1. or to 2.

Not hard to guess that my preference is 1.

WDOT?

Kind regards
Felix

[1] http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
[2] http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Norman Maurer <no...@apache.org>.
go ahead...

Bye,
Norman

2011/2/25, Felix Knecht <fe...@apache.org>:
> On 02/25/2011 11:57 AM, Eric Charles wrote:
>> Hi Felix,
>>
>> I'm with you for 1).
>
> Not sure about how many 'votes' are needed to make a decision. But if
> nobody objects I'll start to eliminate these kind of parent poms and
> provide them via Jira as patch.
>
>>
>> Btw, if you've got commit right to james trunk, I think you can commit
>> directly your changes (in general, referring to a JIRA).
>> We apply CTR, so we can always talk about your commits if needed.
>> Norman, can you confirm this ?
>>
>> Tks,
>> - Eric
>>
>>
>> On 25/02/2011 10:34, Norman wrote:
>>> Hi Felix,
>>>
>>> thanks for starting this.
>>>
>>> I vote for 1) ;)
>>>
>>> Bye,
>>> Norman
>>>
>>> Am 24.02.2011 17:27, schrieb Felix Knecht:
>>>> Hi all
>>>>
>>>> There exists ATM both alternatives about the location of the parent
>>>> pom.xml (see also [1])
>>>>
>>>> "About the parent poms:
>>>> 1.- some projects use the root/pom.xml as parent (james server
>>>> project does that)
>>>> 2. others create a root/parent/pom.xml specific project." [2]
>>>>
>>>> e.g.
>>>> - james/server uses 1.
>>>> - james/imap uses 2.
>>>>
>>>> I think it would be easier to understand for project newbies (like
>>>> me) if this could be harmonized to use either 1. or 2.
>>>>
>>>> Regarding maven-site-plugin used for site generation it's much easier
>>>> to use 1. because this way the site(s) can be generated as multi-module.
>>>> IMO it's also easier to read when just having a single parent pom
>>>> than having (for the same project) a grandparent pom, referenced by a
>>>> parent pom, in which we build the children (<modules>) which
>>>> reference the grandparent pom as parent pom (2.). Sounds weird,
>>>> doesn't it ;-)?
>>>>
>>>> When now deploying e.g. the generated site of james/imap first the
>>>> site of the (grand)parent is deployed to {url} and afterwards it gets
>>>> overridden by the root (parent), which is deployed to the same {url}
>>>>
>>>> I'd like to open the discussion about either switching all james
>>>> projects to 1. or to 2.
>>>>
>>>> Not hard to guess that my preference is 1.
>>>>
>>>> WDOT?
>>>>
>>>> Kind regards
>>>> Felix
>>>>
>>>> [1]
>>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
>>>> [2]
>>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Felix Knecht <fe...@apache.org>.
On 02/25/2011 11:57 AM, Eric Charles wrote:
> Hi Felix,
>
> I'm with you for 1).

Not sure about how many 'votes' are needed to make a decision. But if 
nobody objects I'll start to eliminate these kind of parent poms and 
provide them via Jira as patch.

>
> Btw, if you've got commit right to james trunk, I think you can commit
> directly your changes (in general, referring to a JIRA).
> We apply CTR, so we can always talk about your commits if needed.
> Norman, can you confirm this ?
>
> Tks,
> - Eric
>
>
> On 25/02/2011 10:34, Norman wrote:
>> Hi Felix,
>>
>> thanks for starting this.
>>
>> I vote for 1) ;)
>>
>> Bye,
>> Norman
>>
>> Am 24.02.2011 17:27, schrieb Felix Knecht:
>>> Hi all
>>>
>>> There exists ATM both alternatives about the location of the parent
>>> pom.xml (see also [1])
>>>
>>> "About the parent poms:
>>> 1.- some projects use the root/pom.xml as parent (james server
>>> project does that)
>>> 2. others create a root/parent/pom.xml specific project." [2]
>>>
>>> e.g.
>>> - james/server uses 1.
>>> - james/imap uses 2.
>>>
>>> I think it would be easier to understand for project newbies (like
>>> me) if this could be harmonized to use either 1. or 2.
>>>
>>> Regarding maven-site-plugin used for site generation it's much easier
>>> to use 1. because this way the site(s) can be generated as multi-module.
>>> IMO it's also easier to read when just having a single parent pom
>>> than having (for the same project) a grandparent pom, referenced by a
>>> parent pom, in which we build the children (<modules>) which
>>> reference the grandparent pom as parent pom (2.). Sounds weird,
>>> doesn't it ;-)?
>>>
>>> When now deploying e.g. the generated site of james/imap first the
>>> site of the (grand)parent is deployed to {url} and afterwards it gets
>>> overridden by the root (parent), which is deployed to the same {url}
>>>
>>> I'd like to open the discussion about either switching all james
>>> projects to 1. or to 2.
>>>
>>> Not hard to guess that my preference is 1.
>>>
>>> WDOT?
>>>
>>> Kind regards
>>> Felix
>>>
>>> [1]
>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
>>> [2]
>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Felix Knecht <fe...@apache.org>.
Hi Eric

> I tough you had commit right to james, but that's not the case.

Yep.

> We will for now inject your contributions our selves.

No problem, I'll jsut provide them on Jira as patch.

Regards
Felix

>
> Tks,
> - Eric
>
>
> On 25/02/2011 11:57, Eric Charles wrote:
>> Hi Felix,
>>
>> I'm with you for 1).
>>
>> Btw, if you've got commit right to james trunk, I think you can commit
>> directly your changes (in general, referring to a JIRA).
>> We apply CTR, so we can always talk about your commits if needed.
>> Norman, can you confirm this ?
>>
>> Tks,
>> - Eric
>>
>>
>> On 25/02/2011 10:34, Norman wrote:
>>> Hi Felix,
>>>
>>> thanks for starting this.
>>>
>>> I vote for 1) ;)
>>>
>>> Bye,
>>> Norman
>>>
>>> Am 24.02.2011 17:27, schrieb Felix Knecht:
>>>> Hi all
>>>>
>>>> There exists ATM both alternatives about the location of the parent
>>>> pom.xml (see also [1])
>>>>
>>>> "About the parent poms:
>>>> 1.- some projects use the root/pom.xml as parent (james server
>>>> project does that)
>>>> 2. others create a root/parent/pom.xml specific project." [2]
>>>>
>>>> e.g.
>>>> - james/server uses 1.
>>>> - james/imap uses 2.
>>>>
>>>> I think it would be easier to understand for project newbies (like
>>>> me) if this could be harmonized to use either 1. or 2.
>>>>
>>>> Regarding maven-site-plugin used for site generation it's much
>>>> easier to use 1. because this way the site(s) can be generated as
>>>> multi-module.
>>>> IMO it's also easier to read when just having a single parent pom
>>>> than having (for the same project) a grandparent pom, referenced by
>>>> a parent pom, in which we build the children (<modules>) which
>>>> reference the grandparent pom as parent pom (2.). Sounds weird,
>>>> doesn't it ;-)?
>>>>
>>>> When now deploying e.g. the generated site of james/imap first the
>>>> site of the (grand)parent is deployed to {url} and afterwards it
>>>> gets overridden by the root (parent), which is deployed to the same
>>>> {url}
>>>>
>>>> I'd like to open the discussion about either switching all james
>>>> projects to 1. or to 2.
>>>>
>>>> Not hard to guess that my preference is 1.
>>>>
>>>> WDOT?
>>>>
>>>> Kind regards
>>>> Felix
>>>>
>>>> [1]
>>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
>>>> [2]
>>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Eric Charles <er...@apache.org>.
Hi Felix,
I tough you had commit right to james, but that's not the case.
We will for now inject your contributions our selves.

Tks,
- Eric


On 25/02/2011 11:57, Eric Charles wrote:
> Hi Felix,
>
> I'm with you for 1).
>
> Btw, if you've got commit right to james trunk, I think you can commit 
> directly your changes (in general, referring to a JIRA).
> We apply CTR, so we can always talk about your commits if needed.
> Norman, can you confirm this ?
>
> Tks,
> - Eric
>
>
> On 25/02/2011 10:34, Norman wrote:
>> Hi Felix,
>>
>> thanks for starting this.
>>
>> I vote for 1) ;)
>>
>> Bye,
>> Norman
>>
>> Am 24.02.2011 17:27, schrieb Felix Knecht:
>>> Hi all
>>>
>>> There exists ATM both alternatives about the location of the parent 
>>> pom.xml (see also [1])
>>>
>>> "About the parent poms:
>>> 1.- some projects use the root/pom.xml as parent (james server 
>>> project does that)
>>> 2. others create a root/parent/pom.xml specific project." [2]
>>>
>>> e.g.
>>> - james/server uses 1.
>>> - james/imap uses 2.
>>>
>>> I think it would be easier to understand for project newbies (like 
>>> me) if this could be harmonized to use either 1. or 2.
>>>
>>> Regarding maven-site-plugin used for site generation it's much 
>>> easier to use 1. because this way the site(s) can be generated as 
>>> multi-module.
>>> IMO it's also easier to read when just having a single parent pom 
>>> than having (for the same project) a grandparent pom, referenced by 
>>> a parent pom, in which we build the children (<modules>) which 
>>> reference the grandparent pom as parent pom (2.). Sounds weird, 
>>> doesn't it ;-)?
>>>
>>> When now deploying e.g. the generated site of james/imap first the 
>>> site of the (grand)parent is deployed to {url} and afterwards it 
>>> gets overridden by the root (parent), which is deployed to the same 
>>> {url}
>>>
>>> I'd like to open the discussion about either switching all james 
>>> projects to 1. or to 2.
>>>
>>> Not hard to guess that my preference is 1.
>>>
>>> WDOT?
>>>
>>> Kind regards
>>> Felix
>>>
>>> [1] 
>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
>>> [2] 
>>> http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Eric Charles <er...@apache.org>.
Hi Felix,

I'm with you for 1).

Btw, if you've got commit right to james trunk, I think you can commit 
directly your changes (in general, referring to a JIRA).
We apply CTR, so we can always talk about your commits if needed.
Norman, can you confirm this ?

Tks,
- Eric


On 25/02/2011 10:34, Norman wrote:
> Hi Felix,
>
> thanks for starting this.
>
> I vote for 1) ;)
>
> Bye,
> Norman
>
> Am 24.02.2011 17:27, schrieb Felix Knecht:
>> Hi all
>>
>> There exists ATM both alternatives about the location of the parent 
>> pom.xml (see also [1])
>>
>> "About the parent poms:
>> 1.- some projects use the root/pom.xml as parent (james server 
>> project does that)
>> 2. others create a root/parent/pom.xml specific project." [2]
>>
>> e.g.
>> - james/server uses 1.
>> - james/imap uses 2.
>>
>> I think it would be easier to understand for project newbies (like 
>> me) if this could be harmonized to use either 1. or 2.
>>
>> Regarding maven-site-plugin used for site generation it's much easier 
>> to use 1. because this way the site(s) can be generated as multi-module.
>> IMO it's also easier to read when just having a single parent pom 
>> than having (for the same project) a grandparent pom, referenced by a 
>> parent pom, in which we build the children (<modules>) which 
>> reference the grandparent pom as parent pom (2.). Sounds weird, 
>> doesn't it ;-)?
>>
>> When now deploying e.g. the generated site of james/imap first the 
>> site of the (grand)parent is deployed to {url} and afterwards it gets 
>> overridden by the root (parent), which is deployed to the same {url}
>>
>> I'd like to open the discussion about either switching all james 
>> projects to 1. or to 2.
>>
>> Not hard to guess that my preference is 1.
>>
>> WDOT?
>>
>> Kind regards
>> Felix
>>
>> [1] 
>> http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
>> [2] 
>> http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: Where to put the parent/pom.xml

Posted by Norman <no...@apache.org>.
Hi Felix,

thanks for starting this.

I vote for 1) ;)

Bye,
Norman

Am 24.02.2011 17:27, schrieb Felix Knecht:
> Hi all
>
> There exists ATM both alternatives about the location of the parent 
> pom.xml (see also [1])
>
> "About the parent poms:
> 1.- some projects use the root/pom.xml as parent (james server project 
> does that)
> 2. others create a root/parent/pom.xml specific project." [2]
>
> e.g.
> - james/server uses 1.
> - james/imap uses 2.
>
> I think it would be easier to understand for project newbies (like me) 
> if this could be harmonized to use either 1. or 2.
>
> Regarding maven-site-plugin used for site generation it's much easier 
> to use 1. because this way the site(s) can be generated as multi-module.
> IMO it's also easier to read when just having a single parent pom than 
> having (for the same project) a grandparent pom, referenced by a 
> parent pom, in which we build the children (<modules>) which reference 
> the grandparent pom as parent pom (2.). Sounds weird, doesn't it ;-)?
>
> When now deploying e.g. the generated site of james/imap first the 
> site of the (grand)parent is deployed to {url} and afterwards it gets 
> overridden by the root (parent), which is deployed to the same {url}
>
> I'd like to open the discussion about either switching all james 
> projects to 1. or to 2.
>
> Not hard to guess that my preference is 1.
>
> WDOT?
>
> Kind regards
> Felix
>
> [1] http://www.mail-archive.com/server-dev@james.apache.org/msg31430.html
> [2] http://www.mail-archive.com/server-dev@james.apache.org/msg31440.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org