You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ma...@apache.org on 2010/03/08 16:47:57 UTC
svn commit: r920363 -
/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/
Author: markphip
Date: Mon Mar 8 15:47:57 2010
New Revision: 920363
URL: http://svn.apache.org/viewvc?rev=920363&view=rev
Log:
JavaHL: Change constructors from package protected to public so that
alternate JavaHL implementations like SVNKit do not have to use our package
namespace just so that they can construct these classes.
Patch by: Alexander Kitaev
[ in subversion/bindings/javahl/ ]
* src/org/apache/subversion/javahl/ChangePath.java:
* src/org/apache/subversion/javahl/CommitItem.java:
* src/org/apache/subversion/javahl/ConflictDescriptor.java:
* src/org/apache/subversion/javahl/ConflictVersion.java:
* src/org/apache/subversion/javahl/DiffSummary.java:
* src/org/apache/subversion/javahl/DirEntry.java:
* src/org/apache/subversion/javahl/Info.java:
* src/org/apache/subversion/javahl/Info2.java:
* src/org/apache/subversion/javahl/Lock.java:
* src/org/apache/subversion/javahl/LogMessage.java:
* src/org/apache/subversion/javahl/NotifyInformation.java:
* src/org/apache/subversion/javahl/ProgressEvent.java:
Make constructor public.
Modified:
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java
subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java Mon Mar 8 15:47:57 2010
@@ -42,7 +42,7 @@
* @param action action performed
* @param nodeKind the kind of the changed path
*/
- ChangePath(String path, long copySrcRevision, String copySrcPath,
+ public ChangePath(String path, long copySrcRevision, String copySrcPath,
char action, int nodeKind)
{
this.path = path;
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java Mon Mar 8 15:47:57 2010
@@ -76,7 +76,7 @@
* @param cu copy source url
* @param r revision number
*/
- CommitItem(String p, int nk, int sf, String u, String cu, long r)
+ public CommitItem(String p, int nk, int sf, String u, String cu, long r)
{
path = p;
nodeKind = nk;
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java Mon Mar 8 15:47:57 2010
@@ -92,7 +92,7 @@
private ConflictVersion srcRightVersion;
/** This constructor should only be called from JNI code. */
- ConflictDescriptor(String path, int conflictKind, int nodeKind,
+ public ConflictDescriptor(String path, int conflictKind, int nodeKind,
String propertyName, boolean isBinary, String mimeType,
int action, int reason, int operation,
String basePath, String theirPath,
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java Mon Mar 8 15:47:57 2010
@@ -41,7 +41,7 @@
private int nodeKind;
/** This constructor should only be called from JNI code. */
- ConflictVersion(String reposURL, long pegRevision, String pathInRepos,
+ public ConflictVersion(String reposURL, long pegRevision, String pathInRepos,
int nodeKind)
{
this.reposURL = reposURL;
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java Mon Mar 8 15:47:57 2010
@@ -56,7 +56,7 @@
* @param nodeKind The type of node which changed (corresponds to
* the {@link NodeKind} enumeration).
*/
- DiffSummary(String path, int diffKind, boolean propsChanged,
+ public DiffSummary(String path, int diffKind, boolean propsChanged,
int nodeKind)
{
super(path);
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java Mon Mar 8 15:47:57 2010
@@ -133,7 +133,7 @@
* @param lastChanged the date of the last change
* @param lastAuthor the author of the last change
*/
- DirEntry(String path, String absPath, int nodeKind, long size,
+ public DirEntry(String path, String absPath, int nodeKind, long size,
boolean hasProps, long lastChangedRevision, long lastChanged,
String lastAuthor)
{
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java Mon Mar 8 15:47:57 2010
@@ -113,7 +113,7 @@
* @param copyRev copy source revision
* @param copyUrl copy source url
*/
- Info(String name, String url, String uuid, String repository, int schedule,
+ public Info(String name, String url, String uuid, String repository, int schedule,
int nodeKind, String author, long revision, long lastChangedRevision,
Date lastChangedDate, Date lastDateTextUpdate,
Date lastDatePropsUpdate, boolean copied,
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java Mon Mar 8 15:47:57 2010
@@ -210,7 +210,7 @@
* @param depth
* @param treeConflict
*/
- Info2(String path, String url, long rev, int kind, String reposRootUrl,
+ public Info2(String path, String url, long rev, int kind, String reposRootUrl,
String reposUUID, long lastChangedRev, long lastChangedDate,
String lastChangedAuthor, Lock lock, boolean hasWcInfo, int schedule,
String copyFromUrl, long copyFromRev, long textTime, long propTime,
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java Mon Mar 8 15:47:57 2010
@@ -80,7 +80,7 @@
* @param creationDate the date when the lock was created
* @param expirationDate the date when the lock will expire
*/
- Lock(String owner, String path, String token, String comment,
+ public Lock(String owner, String path, String token, String comment,
long creationDate, long expirationDate)
{
this.owner = owner;
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java Mon Mar 8 15:47:57 2010
@@ -87,7 +87,7 @@
* of microseconds since 00:00:00 January 1,
* 1970 UTC
*/
- LogMessage(Set<ChangePath> cp, long r, String a, Date d, String m)
+ public LogMessage(Set<ChangePath> cp, long r, String a, Date d, String m)
{
changedPaths = cp;
revision = r;
@@ -108,7 +108,7 @@
* @param message the log message text
* @since 1.5
*/
- LogMessage(Set<ChangePath> cp, long r, String a, long t, String m)
+ public LogMessage(Set<ChangePath> cp, long r, String a, long t, String m)
{
changedPaths = cp;
revision = r;
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java Mon Mar 8 15:47:57 2010
@@ -124,7 +124,7 @@
* @param mergeRange The range of the merge just beginning to occur.
* @param pathPrefix A common path prefix.
*/
- NotifyInformation(String path, int action, int kind, String mimeType,
+ public NotifyInformation(String path, int action, int kind, String mimeType,
Lock lock, String errMsg, int contentState,
int propState, int lockState, long revision,
String changelistName, RevisionRange mergeRange,
Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java?rev=920363&r1=920362&r2=920363&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java Mon Mar 8 15:47:57 2010
@@ -58,7 +58,7 @@
* @param total The total number of bytes, or <code>-1</code> if
* not known.
*/
- ProgressEvent(long progress, long total)
+ public ProgressEvent(long progress, long total)
{
this.progress = progress;
this.total = total;
Re: svn commit: r920363 - /subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Mar 8, 2010, at 9:58 AM, Mark Phippard wrote:
> On Mon, Mar 8, 2010 at 10:51 AM, Hyrum K. Wright
> <hy...@mail.utexas.edu> wrote:
>> This means we now need to keep these constructors around for backward compat, yes?
>>
>> (Even in cases where the constructor explicitly says something like "This constructor should only > be called from JNI code."?)
>
> These classes bleed into the ISVNClient interface so they are
> effectively public and ought to be usable by anyone providing an
> implementation of the interface. Another way to approach this would
> be to create additional interfaces for anything that is exposed
> directly or indirectly via ISVNClient and move all of our
> implementation classes into a package names "internal". Then we only
> need to version the interface methods and anyone that uses the
> internal implementation is on their own.
Hmm, yeah. I realize the classes are public, but I guess I always envisioned most of these as "output" parameters which should only be constructed by the internals of JavaHL. Apparently that's not a very accurate vision anymore.
The idea of using interfaces seems like the typical Java solution to this type of question, but it also seems like a lot of work. Using interfaces within interfaces does feel like the cleaner solution, though.
-Hyrum
Re: svn commit: r920363 - /subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Mar 8, 2010 at 10:51 AM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> This means we now need to keep these constructors around for backward compat, yes?
>
> (Even in cases where the constructor explicitly says something like "This constructor should only > be called from JNI code."?)
These classes bleed into the ISVNClient interface so they are
effectively public and ought to be usable by anyone providing an
implementation of the interface. Another way to approach this would
be to create additional interfaces for anything that is exposed
directly or indirectly via ISVNClient and move all of our
implementation classes into a package names "internal". Then we only
need to version the interface methods and anyone that uses the
internal implementation is on their own.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
Re: svn commit: r920363 - /subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
This means we now need to keep these constructors around for backward compat, yes?
(Even in cases where the constructor explicitly says something like "This constructor should only be called from JNI code."?)
-Hyrum
On Mar 8, 2010, at 9:47 AM, markphip@apache.org wrote:
> Author: markphip
> Date: Mon Mar 8 15:47:57 2010
> New Revision: 920363
>
> URL: http://svn.apache.org/viewvc?rev=920363&view=rev
> Log:
> JavaHL: Change constructors from package protected to public so that
> alternate JavaHL implementations like SVNKit do not have to use our package
> namespace just so that they can construct these classes.
>
> Patch by: Alexander Kitaev
>
> [ in subversion/bindings/javahl/ ]
> * src/org/apache/subversion/javahl/ChangePath.java:
> * src/org/apache/subversion/javahl/CommitItem.java:
> * src/org/apache/subversion/javahl/ConflictDescriptor.java:
> * src/org/apache/subversion/javahl/ConflictVersion.java:
> * src/org/apache/subversion/javahl/DiffSummary.java:
> * src/org/apache/subversion/javahl/DirEntry.java:
> * src/org/apache/subversion/javahl/Info.java:
> * src/org/apache/subversion/javahl/Info2.java:
> * src/org/apache/subversion/javahl/Lock.java:
> * src/org/apache/subversion/javahl/LogMessage.java:
> * src/org/apache/subversion/javahl/NotifyInformation.java:
> * src/org/apache/subversion/javahl/ProgressEvent.java:
> Make constructor public.
>
> Modified:
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java
> subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ChangePath.java Mon Mar 8 15:47:57 2010
> @@ -42,7 +42,7 @@
> * @param action action performed
> * @param nodeKind the kind of the changed path
> */
> - ChangePath(String path, long copySrcRevision, String copySrcPath,
> + public ChangePath(String path, long copySrcRevision, String copySrcPath,
> char action, int nodeKind)
> {
> this.path = path;
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/CommitItem.java Mon Mar 8 15:47:57 2010
> @@ -76,7 +76,7 @@
> * @param cu copy source url
> * @param r revision number
> */
> - CommitItem(String p, int nk, int sf, String u, String cu, long r)
> + public CommitItem(String p, int nk, int sf, String u, String cu, long r)
> {
> path = p;
> nodeKind = nk;
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java Mon Mar 8 15:47:57 2010
> @@ -92,7 +92,7 @@
> private ConflictVersion srcRightVersion;
>
> /** This constructor should only be called from JNI code. */
> - ConflictDescriptor(String path, int conflictKind, int nodeKind,
> + public ConflictDescriptor(String path, int conflictKind, int nodeKind,
> String propertyName, boolean isBinary, String mimeType,
> int action, int reason, int operation,
> String basePath, String theirPath,
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictVersion.java Mon Mar 8 15:47:57 2010
> @@ -41,7 +41,7 @@
> private int nodeKind;
>
> /** This constructor should only be called from JNI code. */
> - ConflictVersion(String reposURL, long pegRevision, String pathInRepos,
> + public ConflictVersion(String reposURL, long pegRevision, String pathInRepos,
> int nodeKind)
> {
> this.reposURL = reposURL;
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DiffSummary.java Mon Mar 8 15:47:57 2010
> @@ -56,7 +56,7 @@
> * @param nodeKind The type of node which changed (corresponds to
> * the {@link NodeKind} enumeration).
> */
> - DiffSummary(String path, int diffKind, boolean propsChanged,
> + public DiffSummary(String path, int diffKind, boolean propsChanged,
> int nodeKind)
> {
> super(path);
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/DirEntry.java Mon Mar 8 15:47:57 2010
> @@ -133,7 +133,7 @@
> * @param lastChanged the date of the last change
> * @param lastAuthor the author of the last change
> */
> - DirEntry(String path, String absPath, int nodeKind, long size,
> + public DirEntry(String path, String absPath, int nodeKind, long size,
> boolean hasProps, long lastChangedRevision, long lastChanged,
> String lastAuthor)
> {
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info.java Mon Mar 8 15:47:57 2010
> @@ -113,7 +113,7 @@
> * @param copyRev copy source revision
> * @param copyUrl copy source url
> */
> - Info(String name, String url, String uuid, String repository, int schedule,
> + public Info(String name, String url, String uuid, String repository, int schedule,
> int nodeKind, String author, long revision, long lastChangedRevision,
> Date lastChangedDate, Date lastDateTextUpdate,
> Date lastDatePropsUpdate, boolean copied,
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Info2.java Mon Mar 8 15:47:57 2010
> @@ -210,7 +210,7 @@
> * @param depth
> * @param treeConflict
> */
> - Info2(String path, String url, long rev, int kind, String reposRootUrl,
> + public Info2(String path, String url, long rev, int kind, String reposRootUrl,
> String reposUUID, long lastChangedRev, long lastChangedDate,
> String lastChangedAuthor, Lock lock, boolean hasWcInfo, int schedule,
> String copyFromUrl, long copyFromRev, long textTime, long propTime,
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/Lock.java Mon Mar 8 15:47:57 2010
> @@ -80,7 +80,7 @@
> * @param creationDate the date when the lock was created
> * @param expirationDate the date when the lock will expire
> */
> - Lock(String owner, String path, String token, String comment,
> + public Lock(String owner, String path, String token, String comment,
> long creationDate, long expirationDate)
> {
> this.owner = owner;
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/LogMessage.java Mon Mar 8 15:47:57 2010
> @@ -87,7 +87,7 @@
> * of microseconds since 00:00:00 January 1,
> * 1970 UTC
> */
> - LogMessage(Set<ChangePath> cp, long r, String a, Date d, String m)
> + public LogMessage(Set<ChangePath> cp, long r, String a, Date d, String m)
> {
> changedPaths = cp;
> revision = r;
> @@ -108,7 +108,7 @@
> * @param message the log message text
> * @since 1.5
> */
> - LogMessage(Set<ChangePath> cp, long r, String a, long t, String m)
> + public LogMessage(Set<ChangePath> cp, long r, String a, long t, String m)
> {
> changedPaths = cp;
> revision = r;
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/NotifyInformation.java Mon Mar 8 15:47:57 2010
> @@ -124,7 +124,7 @@
> * @param mergeRange The range of the merge just beginning to occur.
> * @param pathPrefix A common path prefix.
> */
> - NotifyInformation(String path, int action, int kind, String mimeType,
> + public NotifyInformation(String path, int action, int kind, String mimeType,
> Lock lock, String errMsg, int contentState,
> int propState, int lockState, long revision,
> String changelistName, RevisionRange mergeRange,
>
> Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java?rev=920363&r1=920362&r2=920363&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java (original)
> +++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/ProgressEvent.java Mon Mar 8 15:47:57 2010
> @@ -58,7 +58,7 @@
> * @param total The total number of bytes, or <code>-1</code> if
> * not known.
> */
> - ProgressEvent(long progress, long total)
> + public ProgressEvent(long progress, long total)
> {
> this.progress = progress;
> this.total = total;
>
>