You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/12/19 19:02:34 UTC
Review Request 29258: [FALCON-960] Enable FalconClientTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-960
https://issues.apache.org/jira/browse/FALCON-960
Repository: falcon-git
Description
-------
Removed redundunt code. Enabled tests.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
Diff: https://reviews.apache.org/r/29258/diff/
Testing
-------
Tests fail now because both submit and delete actions are permitted for user different from in ACL.
Thanks,
Paul Isaychuk
Re: Review Request 29258: [FALCON-960] Enable FalconClientTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On Jan. 2, 2015, 7:04 p.m., Raghav Gautam wrote:
> > Can you please mention why is it not tested ? If the tests are failing because of a bug - can you mention the jiras ?
The reason is that I had spent much time to configure local secure vagrant cluster to launch this test but I still had different environment issues related to keytabs, permissions stuff etc.
Thats why I didn't test it. I asked about it in one of the letters.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/#review66538
-----------------------------------------------------------
On Jan. 2, 2015, 4:15 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29258/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 4:15 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-960
> https://issues.apache.org/jira/browse/FALCON-960
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Removed redundunt code. Enabled tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
>
> Diff: https://reviews.apache.org/r/29258/diff/
>
>
> Testing
> -------
>
> Not tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29258: [FALCON-960] Enable FalconClientTest
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/#review66538
-----------------------------------------------------------
Can you please mention why is it not tested ? If the tests are failing because of a bug - can you mention the jiras ?
- Raghav Gautam
On Jan. 2, 2015, 8:15 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29258/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 8:15 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-960
> https://issues.apache.org/jira/browse/FALCON-960
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Removed redundunt code. Enabled tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
>
> Diff: https://reviews.apache.org/r/29258/diff/
>
>
> Testing
> -------
>
> Not tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 29258: [FALCON-960] Enable FalconClientTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/
-----------------------------------------------------------
(Updated Jan. 2, 2015, 4:15 p.m.)
Review request for Falcon.
Bugs: FALCON-960
https://issues.apache.org/jira/browse/FALCON-960
Repository: falcon-git
Description
-------
Removed redundunt code. Enabled tests.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
Diff: https://reviews.apache.org/r/29258/diff/
Testing (updated)
-------
Not tested
Thanks,
Paul Isaychuk
Re: Review Request 29258: [FALCON-960] Enable FalconClientTest
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 8:27 a.m.)
Review request for Falcon.
Bugs: FALCON-960
https://issues.apache.org/jira/browse/FALCON-960
Repository: falcon-git
Description
-------
Removed redundunt code. Enabled tests.
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
Diff: https://reviews.apache.org/r/29258/diff/
Testing
-------
Tests fail now because both submit and delete actions are permitted for user different from in ACL.
Thanks,
Paul Isaychuk
Re: Review Request 29258: [FALCON-960] Enable FalconClientTest
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29258/#review65785
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
<https://reviews.apache.org/r/29258/#comment109035>
why 'embedded' group is added?
- Ruslan Ostafiychuk
On Dec. 19, 2014, 6:02 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29258/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 6:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-960
> https://issues.apache.org/jira/browse/FALCON-960
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Removed redundunt code. Enabled tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java 1b5750a
>
> Diff: https://reviews.apache.org/r/29258/diff/
>
>
> Testing
> -------
>
> Tests fail now because both submit and delete actions are permitted for user different from in ACL.
>
>
> Thanks,
>
> Paul Isaychuk
>
>