[jira] [Commented] (CARBONDATA-233) bad record logger support for non parseable numeric and timestamp data

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CARBONDATA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554365#comment-15554365 ] 

ASF GitHub Bot commented on CARBONDATA-233:
-------------------------------------------

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/148#discussion_r82339778
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordslogger.java ---
    @@ -89,41 +95,55 @@ public static String hasBadRecord(String key) {
         return badRecordEntry.remove(key);
       }
     
    -  public void addBadRecordsToBilder(Object[] row, int size, String reason, String valueComparer) {
    +  public void addBadRecordsToBuilder(Object[] row, int size, String reason, String valueComparer,
    +      boolean badRecordsLogRedirect, boolean badRecordLoggerEnable) {
         StringBuilder logStrings = new StringBuilder();
    +    size = row.length;
    --- End diff --
    
    better to validate whether we need to log the bad record in the starting of method, and then continue the log string creation logic


> bad record logger support for non parseable numeric and timestamp data
> ----------------------------------------------------------------------
>
>                 Key: CARBONDATA-233
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-233
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Mohammad Shahid Khan
>            Assignee: Mohammad Shahid Khan
>
> bad record logger support for non parseable numeric and timestamp data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)