You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "CTTY (via GitHub)" <gi...@apache.org> on 2025/06/18 23:18:18 UTC

Re: [PR] feat: add retryable property for Error [iceberg-rust]

CTTY commented on code in PR #1383:
URL: https://github.com/apache/iceberg-rust/pull/1383#discussion_r2155706397


##########
crates/iceberg/src/error.rs:
##########
@@ -134,6 +134,8 @@ pub struct Error {
 
     source: Option<anyhow::Error>,
     backtrace: Backtrace,
+
+    retryable: bool,

Review Comment:
   I'm not sure I fully understand the benefits of having an `ErrorStatus` within `Error` to define if an error is temporary. This basically means we can mark any `ErrorKind` as "retryable". Maybe there is any concrete example?
   
   On the other hand, I think adding a dedicated `ErrorKind` like `CommitFailed` for commit conflicts doesn't conflict with the idea of having an `ErrorStatus`---we can have both if necessary. Opened #1452 based on this thought, would be happy to hear your thoughts as well!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org