[GitHub] [accumulo] foster33 commented on a change in pull request #2180: Update CheckForMetadataProblems Utility Output

[GitBox <gi...@apache.org>]

foster33 commented on a change in pull request #2180:
URL: https://github.com/apache/accumulo/pull/2180#discussion_r658177554



##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/CheckForMetadataProblems.java
##########
@@ -125,7 +128,12 @@ private static void checkMetadataAndRootTableEntries(String tableNameToCheck, Se
         TreeSet<KeyExtent> tablets = tables.get(tableId);
         if (tablets == null) {
 
-          tables.forEach(CheckForMetadataProblems::checkTable);
+          for (Entry<TableId,TreeSet<KeyExtent>> e : tables.entrySet()) {
+            TableId key = e.getKey();
+            TreeSet<KeyExtent> value = e.getValue();
+            String tableName = Tables.getTableName(opts.getServerContext(), key);
+            checkTable(key, value, tableName);
+          }

Review comment:
       >Also, need to handle the case that looking up the name fails, in case the table is deleted, but there is still metadata left in the metadata tablet
   
   Is there any way that I would easily be able to recreate this error in testing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org