You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@community.apache.org by GitBox <gi...@apache.org> on 2020/11/13 18:04:03 UTC
[GitHub] [comdev-site] turbaszek opened a new pull request #17: Add Open Graph metadata for better previews in social media
turbaszek opened a new pull request #17:
URL: https://github.com/apache/comdev-site/pull/17
Hello,
This PR aims to add Open Graph metadata to improve rendering previews of ComDev site in social medias.
I'm not sure how to test it locally, but I based my work on:
https://gohugo.io/templates/internal/#open-graph
https://github.com/thingsym/hugo-theme-techdoc/blob/master/exampleSite/config.toml
Added photos are part of ACEU19 gallery:
https://photos.apachecon.com/picture.php?/395/category/1
https://photos.apachecon.com/picture.php?/253/category/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] bdelacretaz commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728139649
I'm fine with merging this and I don't think there's any trademarks impact as this is only adding metadata to the http://community.apache.org/ pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] bdelacretaz commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728040289
I built the site locally with these changes and the homepage has no difference with a build that does not have them.
I'm not familiar with OpenGraph and have only limited experience with Hugo but as per https://gohugo.io/templates/internal/ I tried the following change:
diff --git a/layouts/_default/baseof.html b/layouts/_default/baseof.html
index f7f5f49..ff7ebfe 100644
--- a/layouts/_default/baseof.html
+++ b/layouts/_default/baseof.html
@@ -50,6 +50,7 @@
margin-top:1em;
}
</style>
+ {{ template "_internal/opengraph.html" . }}
</head>
<body>
And with this I see a number of `<meta>` elements on the homepage:
<meta property="og:title" content="Apache Community Development - Welcome" />
<meta property="og:description" content="The Community Development project creates and provides tools, processes, and advice to help open-source software projects improve their own community health." />
<meta property="og:type" content="website" />
<meta property="og:url" content="http://localhost:1313/" />
<meta property="og:image" content="http://localhost:1313/images/aceu19_1.jpg"/>
<meta property="og:site_name" content="Apache Community Development" />
So I suppose we should make this template change in addition to the changes in this PR, to include the OpenGraph metadata in the site pages? Or is there another way to access this new metadata that I'm missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728093377
> So I suppose we should make this template change in addition to the changes in this PR, to include the OpenGraph metadata in the site pages? Or is there another way to access this new metadata that I'm missing?
Seems I missed this part of documentation! Looks good now:
![Uploading Screenshot 2020-11-16 at 15.21.59.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek merged pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #17:
URL: https://github.com/apache/comdev-site/pull/17
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek edited a comment on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek edited a comment on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728093377
> So I suppose we should make this template change in addition to the changes in this PR, to include the OpenGraph metadata in the site pages? Or is there another way to access this new metadata that I'm missing?
Seems I missed this part of documentation! Looks good now:
<img width="1109" alt="Screenshot 2020-11-16 at 15 21 59" src="https://user-images.githubusercontent.com/9528307/99263546-a73fb700-281f-11eb-9d6e-01baf54401bd.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] bdelacretaz commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728095717
> Looks good now..
Out of curiosity, which tool are you using the check those previews?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728097670
Based on one SO thread I did this:
```
hugo server -D
lt --port 1313
```
The `lt` command is the [localtunnel](https://localtunnel.github.io/www/) command which works similar to ngrok. Then I check the generated url using https://www.opengraph.xyz
Simpler than I expected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728136577
Eventually pinging @markt-asf for opinion as this is somehow related to ASF branding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
[GitHub] [comdev-site] turbaszek commented on pull request #17: Add Open Graph metadata for better previews in social media
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #17:
URL: https://github.com/apache/comdev-site/pull/17#issuecomment-728135844
@bdelacretaz do we wait for more approvals or we are good to merge this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org