You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Akila Ravihansa Perera <ra...@wso2.com> on 2014/04/16 13:06:37 UTC
Puppet modeule "agent" start.pp issue
Hi,
I found this discrepancy in "agent" Puppet module's start.pp script [1].
exec { "starting_${name}":
user => $owner,
path =>
'/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/java/bin/',
unless => "test -f ${target}/wso2carbon.lck",
cwd => "${target}/bin/",
command => "touch ${target}/wso2carbon.lck; bash stratos.sh > /dev/null
2>&1 &",
}
The above command "bash stratos.sh" seems to be wrong. Shouldn't it include
the path to Stratos agent like follows;
${target}/bin/stratos.sh > /dev/null 2>&1 &
Pl confirm. Thanks.
[1] -
https://github.com/apache/incubator-stratos/blob/master/tools/puppet3/modules/agent/manifests/start.pp#L26
--
Akila Ravihansa Perera
Software Engineer
WSO2 Inc.
http://wso2.com
Phone: +94 77 64 154 38
Blog: http://ravihansa3000.blogspot.com
Re: Puppet modeule "agent" start.pp issue
Posted by Thilina Piyasundara <th...@gmail.com>.
no need ...
Its changing the location (current working directory) by;
cwd => "${target}/bin/",
On Wed, Apr 16, 2014 at 4:36 PM, Akila Ravihansa Perera
<ra...@wso2.com>wrote:
> Hi,
>
> I found this discrepancy in "agent" Puppet module's start.pp script [1].
>
> exec { "starting_${name}":
> user => $owner,
> path =>
> '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/java/bin/',
> unless => "test -f ${target}/wso2carbon.lck",
> cwd => "${target}/bin/",
> command => "touch ${target}/wso2carbon.lck; bash stratos.sh >
> /dev/null 2>&1 &",
> }
>
> The above command "bash stratos.sh" seems to be wrong. Shouldn't it
> include the path to Stratos agent like follows;
>
> ${target}/bin/stratos.sh > /dev/null 2>&1 &
>
> Pl confirm. Thanks.
>
> [1] -
> https://github.com/apache/incubator-stratos/blob/master/tools/puppet3/modules/agent/manifests/start.pp#L26
>
> --
> Akila Ravihansa Perera
> Software Engineer
> WSO2 Inc.
> http://wso2.com
>
> Phone: +94 77 64 154 38
> Blog: http://ravihansa3000.blogspot.com
>
--
Thanks and regards,
Thilina Piyasundara.
Re: Puppet modeule "agent" start.pp issue
Posted by Isuru Perera <is...@wso2.com>.
Did you encounter any issues?
On Wed, Apr 16, 2014 at 4:36 PM, Akila Ravihansa Perera
<ra...@wso2.com>wrote:
> Hi,
>
> I found this discrepancy in "agent" Puppet module's start.pp script [1].
>
> exec { "starting_${name}":
> user => $owner,
> path =>
> '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/java/bin/',
> unless => "test -f ${target}/wso2carbon.lck",
> cwd => "${target}/bin/",
> command => "touch ${target}/wso2carbon.lck; bash stratos.sh >
> /dev/null 2>&1 &",
> }
>
> The above command "bash stratos.sh" seems to be wrong. Shouldn't it
> include the path to Stratos agent like follows;
>
> ${target}/bin/stratos.sh > /dev/null 2>&1 &
>
> Pl confirm. Thanks.
>
> [1] -
> https://github.com/apache/incubator-stratos/blob/master/tools/puppet3/modules/agent/manifests/start.pp#L26
>
> --
> Akila Ravihansa Perera
> Software Engineer
> WSO2 Inc.
> http://wso2.com
>
> Phone: +94 77 64 154 38
> Blog: http://ravihansa3000.blogspot.com
>
--
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware
about.me/chrishantha
Re: Puppet modeule "agent" start.pp issue
Posted by Dinesh Bandara <di...@wso2.com>.
Hi,
There is 'cwd' [1]. the external commands execute form that given directory
[1] http://docs.puppetlabs.com/references/latest/type.html#exec-attributes
On Wed, Apr 16, 2014 at 4:36 PM, Akila Ravihansa Perera
<ra...@wso2.com>wrote:
> Hi,
>
> I found this discrepancy in "agent" Puppet module's start.pp script [1].
>
> exec { "starting_${name}":
> user => $owner,
> path =>
> '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/java/bin/',
> unless => "test -f ${target}/wso2carbon.lck",
> cwd => "${target}/bin/",
> command => "touch ${target}/wso2carbon.lck; bash stratos.sh >
> /dev/null 2>&1 &",
> }
>
> The above command "bash stratos.sh" seems to be wrong. Shouldn't it
> include the path to Stratos agent like follows;
>
> ${target}/bin/stratos.sh > /dev/null 2>&1 &
>
> Pl confirm. Thanks.
>
> [1] -
> https://github.com/apache/incubator-stratos/blob/master/tools/puppet3/modules/agent/manifests/start.pp#L26
>
> --
> Akila Ravihansa Perera
> Software Engineer
> WSO2 Inc.
> http://wso2.com
>
> Phone: +94 77 64 154 38
> Blog: http://ravihansa3000.blogspot.com
>
--
*Dinesh Bandara*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware