[GitHub] [myfaces] tandraschko commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)

[GitBox <gi...@apache.org>]

tandraschko commented on code in PR #366:
URL: https://github.com/apache/myfaces/pull/366#discussion_r1017675637


##########
api/src/main/java/jakarta/faces/component/UIComponent.java:
##########
@@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue)
             }
         }
     }
+
+    private Resource getLocalizedCompositeResource(String resourceName, String libraryName, FacesContext context) 
+    {
+    	List<String> localizedPaths = getLocalizedPropertiesPaths(resourceName, context);
+    	Resource resource = null;
+    	
+    	for (String path_: localizedPaths) {
+    		resource = context.getApplication().getResourceHandler().createResource(path_, libraryName);
+    		if (resource != null)

Review Comment:
   please dont use tabs and make { in new line
   no idea, i thought our checkstyle would fail
   also better name path_ into localizedPath



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org