You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2016/07/22 09:17:20 UTC
[jira] [Commented] (LUCENE-7389) Validation issue in
FieldType#setDimensions?
[ https://issues.apache.org/jira/browse/LUCENE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389197#comment-15389197 ]
Michael McCandless commented on LUCENE-7389:
--------------------------------------------
YES!
> Validation issue in FieldType#setDimensions?
> --------------------------------------------
>
> Key: LUCENE-7389
> URL: https://issues.apache.org/jira/browse/LUCENE-7389
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Martijn van Groningen
>
> It compares if the {{dimensionCount}} is larger than {{PointValues.MAX_NUM_BYTES}} while this constant should be compared to {{dimensionNumBytes}} instead?
> So this if statement:
> {noformat}
> if (dimensionCount > PointValues.MAX_NUM_BYTES) {
> throw new IllegalArgumentException("dimensionNumBytes must be <= " + PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
> }
> {noformat}
> Should be:
> {noformat}
> if (dimensionNumBytes > PointValues.MAX_NUM_BYTES) {
> throw new IllegalArgumentException("dimensionNumBytes must be <= " + PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org