You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/09 23:33:08 UTC
[kudu-CR] [consensus] add queue/cmeta consistency DCHECK
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9272
Change subject: [consensus] add queue/cmeta consistency DCHECK
......................................................................
[consensus] add queue/cmeta consistency DCHECK
Added an assertion on the consistency of the consensus metadata and
the consensus queue (effective for DEBUG builds only).
This is in the context of tracking and fixing the bug we hit earlier,
and we guess it happened because of the issue described in KUDU-2274.
Change-Id: Id9c7a16add29c8ab0228085c2009ee17a435d3e8
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
3 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/9272/1
--
To view, visit http://gerrit.cloudera.org:8080/9272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9c7a16add29c8ab0228085c2009ee17a435d3e8
Gerrit-Change-Number: 9272
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] add queue/cmeta consistency DCHECK
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9272 )
Change subject: [consensus] add queue/cmeta consistency DCHECK
......................................................................
[consensus] add queue/cmeta consistency DCHECK
Added an assertion on the consistency of the consensus metadata and
the consensus queue (effective for DEBUG builds only).
This is in the context of tracking and fixing the bug we hit earlier,
and we guess it happened because of the issue described in KUDU-2274.
Change-Id: Id9c7a16add29c8ab0228085c2009ee17a435d3e8
Reviewed-on: http://gerrit.cloudera.org:8080/9272
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
3 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9c7a16add29c8ab0228085c2009ee17a435d3e8
Gerrit-Change-Number: 9272
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus] add queue/cmeta consistency DCHECK
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9272 )
Change subject: [consensus] add queue/cmeta consistency DCHECK
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c7a16add29c8ab0228085c2009ee17a435d3e8
Gerrit-Change-Number: 9272
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 02:06:27 +0000
Gerrit-HasComments: No