You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/09 17:23:36 UTC

[GitHub] [lucenenet] NightOwl888 opened a new pull request, #755: BUG: Fixed TokenAttributes to specify interfaces instead of concrete types, where appropriate

NightOwl888 opened a new pull request, #755:
URL: https://github.com/apache/lucenenet/pull/755

   Since we have (somewhat confusingly) renamed our token attribute types to conform with .NET conventions:
   
   |  | Lucene | Lucene.NET |
   | ---- |  ---- | ---- |
   | Concrete type | XxxAttributeImpl | XxxAttribute |
   | Interface type | XxxAttribute | IXxxAttribute |
   
   We had miswired some of the attributes, using the concrete type instead of the interface. This fixes that as well as:
   
   1. Renames all of the file names back to their original Lucene names (with the exception of the file extension)
   2. Updates the documentation that refers to interfaces to show the appropriate type
   3. Adds guard clauses to all token attribute members
   
   Also included in this PR:
   
   1. **PEROFORMANCE:** `[Lucene.Net.Analysis.Sinks.DateRecognizerSinkFilter`: Prefer `ReadOnlySpan<char>` overloads of `DateTime.TryParse()` and `DateTime.TryParseExact()`, when available.
   2. **BREAKING:** `Lucene.Net.Analysis.Kuromoji.Token`: Renamed `IsKnown()` > `IsKnown`, `IsUnknown()` > IsUnknown`, `IsUser()` > `IsUser`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #755: BUG: Fixed TokenAttributes to specify interfaces instead of concrete types, where appropriate

Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #755:
URL: https://github.com/apache/lucenenet/pull/755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org