You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/02/22 07:37:46 UTC

[GitHub] [incubator-eventmesh] lrhkobe opened a new pull request #781: [Issue #780] Modify the define level of EventListener from Topic to Consumer

lrhkobe opened a new pull request #781:
URL: https://github.com/apache/incubator-eventmesh/pull/781


   
   
   ### Motivation
   
   The logic of EventListner is same for each topic in EventMesh, and if new  an object of EventListner in heap for each topic, may lead to memory waste.
   
   
   
   ### Modifications
   
   - modify method `subscribe` in `Consumer.java`, delete the binding between topic and eventListener
   ```
     //void subscribe(String topic, final EventListener listener) throws Exception;
   
       void subscribe(String topic) throws Exception;
   ```
   - add method `registerEventListener` in `Consumer.java` , regist eventListener and store it in the level of Consumer
   ```
       void registerEventListener(EventListener listener);
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #781: [Issue #780] Modify the define level of EventListener from Topic to Consumer

Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #781:
URL: https://github.com/apache/incubator-eventmesh/pull/781


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org