[GitHub] spark pull request #21006: [SPARK-22256][MESOS] - Introduce spark.mesos.driv...

[tnachen <gi...@git.apache.org>]

Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21006#discussion_r207060617
  
    --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala ---
    @@ -199,6 +200,33 @@ class MesosClusterSchedulerSuite extends SparkFunSuite with LocalSparkContext wi
         })
       }
     
    +  test("supports spark.mesos.driver.memoryOverhead") {
    +    setScheduler()
    +
    +    val mem = 1000
    +    val cpu = 1
    +
    +    val response = scheduler.submitDriver(
    +      new MesosDriverDescription("d1", "jar", mem, cpu, true,
    +        command,
    +        Map("spark.mesos.executor.home" -> "test",
    +          "spark.app.name" -> "test"),
    +        "s1",
    +        new Date()))
    +    assert(response.success)
    +
    +    val offer = Utils.createOffer("o1", "s1", mem*2, cpu)
    +    scheduler.resourceOffers(driver, List(offer).asJava)
    +    val tasks = Utils.verifyTaskLaunched(driver, "o1")
    +    // 1384.0
    +    val taskMem = tasks.head.getResourcesList
    +      .asScala
    +      .filter(_.getName.equals("mem"))
    +      .map(_.getScalar.getValue)
    +      .head
    +    assert(1384.0 === taskMem)
    --- End diff --
    
    Can we also test the 10% case as well?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org