You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 10:14:18 UTC

[GitHub] [airflow] kaxil commented on pull request #16577: Exclude ``yarn.lock`` from release packages

kaxil commented on pull request #16577:
URL: https://github.com/apache/airflow/pull/16577#issuecomment-865854877


   @potiuk @uranusjr Did you guys actually try out? I had, unless I missed something (which is also possible :) )
   
   The same link that you used Jarek explain the three options:
   
   https://setuptools.readthedocs.io/en/latest/userguide/datafiles.html
   
   ![image](https://user-images.githubusercontent.com/8811558/122906976-98d3f380-d34a-11eb-94ee-e8ee8e368366.png)
   
   If a package has `include_package_data` as `True`, `MANIFEST.in` is also used. Also summarized somewhat in https://github.com/pypa/setuptools/issues/511#issuecomment-570177072
   
   @potiuk I would want to continue with this PR and you can optimize it in yours. I have updated the PR title and description to say I want to exclude yarn.lock file from both tar.gz and .whl


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org