You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/25 19:06:13 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30503: [SPARK-26645][PYTHON] Support decimals with negative scale when parsing datatype
dongjoon-hyun opened a new pull request #30503:
URL: https://github.com/apache/spark/pull/30503
## What changes were proposed in this pull request?
This is a backport of #23575
When parsing datatypes from the json internal representation, PySpark doesn't support decimals with negative scales. Since they are allowed and can actually happen, PySpark should be able to successfully parse them.
## How was this patch tested?
added test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30503:
URL: https://github.com/apache/spark/pull/30503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733982544
Thank you, @viirya !
Merged to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733921583
There was a community request at SPARK-33445 and SPARK-26645 for backporting this to `branch-2.4`.
Since `Apache Spark 2.4.x` is LTS, it would be great if we can have this.
cc @HyukjinKwon , @BryanCutler , @srowen , @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733922311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733899149
**[Test build #131800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131800/testReport)** for PR 30503 at commit [`1f1592e`](https://github.com/apache/spark/commit/1f1592e023613fd515c3324245c37ad88149a32a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733966631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733919389
**[Test build #131800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131800/testReport)** for PR 30503 at commit [`1f1592e`](https://github.com/apache/spark/commit/1f1592e023613fd515c3324245c37ad88149a32a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733922311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-733899149
**[Test build #131800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131800/testReport)** for PR 30503 at commit [`1f1592e`](https://github.com/apache/spark/commit/1f1592e023613fd515c3324245c37ad88149a32a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30503: [SPARK-26645][PYTHON][2.4] Support decimals with negative scale when parsing datatype
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30503:
URL: https://github.com/apache/spark/pull/30503#issuecomment-734023750
Nice, thanks @dongjoon-hyun and @viirya.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org