You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/24 09:18:04 UTC

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #14441: optimize updateServiceUrl method

lordcheng10 commented on a change in pull request #14441:
URL: https://github.com/apache/pulsar/pull/14441#discussion_r813686002



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -860,6 +860,10 @@ public boolean isClosed() {
 
     @Override
     public synchronized void updateServiceUrl(String serviceUrl) throws PulsarClientException {
+        if (serviceUrl != null && serviceUrl.equals(conf.getServiceUrl())) {
+            log.info("Ignore service URL to {}，because it is the same as the current service URL!", serviceUrl);

Review comment:
       ![image](https://user-images.githubusercontent.com/19296967/155494985-e03cd038-e4e0-4124-a3b9-c39f5d06be4c.png)
   Aha, I made a mistake, here is the judgment of whether the url is equal.  I will close this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org