You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/20 17:34:20 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11393: [DRAFT] Make StateBacked validation test run against any runner

robertwb commented on a change in pull request #11393:
URL: https://github.com/apache/beam/pull/11393#discussion_r407608845



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##########
@@ -1606,7 +1607,7 @@ def __init__(self, num_elements, unused):
     StateBackedTestElementType.live_element_count += 1
     # Due to using state backed iterable, we expect there is a few instances
     # alive at any given time.
-    if StateBackedTestElementType.live_element_count > 5:
+    if StateBackedTestElementType.live_element_count > 200:

Review comment:
       This test (specifically setting use_state_iterables in the runner construction) is specific to the FnApIRunner. Rather than trying to re-use this, we should probably have a separate, more generic test. Anything that produces more than 2GB of values for a single key should work (but that would not be an appropriate unit test). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org