You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/05/25 18:42:07 UTC

[superset] branch hugh/bg-patch created (now 647bc7c)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh/bg-patch
in repository https://gitbox.apache.org/repos/asf/superset.git.


      at 647bc7c  Update schemas.py

This branch includes the following new commits:

     new 647bc7c  Update schemas.py

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


[superset] 01/01: Update schemas.py

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/bg-patch
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 647bc7c056ca23bb087afce1a24a94a485c84a7a
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Tue May 25 14:40:47 2021 -0400

    Update schemas.py
---
 superset/databases/schemas.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py
index e952967..6bd2abd 100644
--- a/superset/databases/schemas.py
+++ b/superset/databases/schemas.py
@@ -252,7 +252,8 @@ class DatabaseParametersSchemaMixin:
         # frontend is not passing engine inside parameters
         engine = data.pop("engine", None) or parameters.pop("engine", None)
 
-        if parameters:
+        configuration_method = data.get('configuration_method')
+        if configuration_method == ConfigurationMethod.DYNAMIC_FORM:
             if not engine:
                 raise ValidationError(
                     [