Re: [PR] [SPARK-45626][SQL] Fix variable name of error-class & convert _LEGACY_ERROR_TEMP_1055 to REQUIRES_SINGLE_PART_NAMESPACE [spark]

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #43479:
URL: https://github.com/apache/spark/pull/43479#discussion_r1368087736


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1553,6 +1553,11 @@
     },
     "sqlState" : "HY109"
   },
+  "INVALID_DATABASE_NAME" : {

Review Comment:
   Maybe we can re-use error class: `REQUIRES_SINGLE_PART_NAMESPACE`?
   But the prompt message is called `namespace` instead of `database`, seems to be okay? I'm too sure
   https://github.com/apache/spark/blob/376de8a502fca6b46d7f21560a60024d643144ea/common/utils/src/main/resources/error/error-classes.json#L2784-L2789



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org