You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "fabio-rizzo-01 (via GitHub)" <gi...@apache.org> on 2025/09/29 09:25:40 UTC

[PR] Updating metastore documentation with Aurora postgres example [polaris]

fabio-rizzo-01 opened a new pull request, #2706:
URL: https://github.com/apache/polaris/pull/2706

   <!--
       Possible security vulnerabilities: STOP here and contact security@apache.org instead!
   
       Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
       Please update this summary field:
   
       The summary should cover these topics, if applicable:
       * the motivation for the change
       * a description of the status quo, for example the current behavior
       * the desired behavior
       * etc
   
       PR checklist:
       - Do a self-review of your code before opening a pull request
       - Make sure that there's good test coverage for the changes included in this PR
       - Run tests locally before pushing a PR (./gradlew check)
       - Code should have comments where applicable. Particularly hard-to-understand
         areas deserve good in-line documentation.
       - Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
       - For Work In Progress Pull Requests, please use the Draft PR feature.
   
       Make sure to add the information BELOW this comment.
       Everything in this comment will NOT be added to the PR description.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2706:
URL: https://github.com/apache/polaris/pull/2706#issuecomment-3357930672

   @fabio-rizzo-01 : please rebase to fix CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2388464460


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   please check this feedback from @dimas-b 
   https://github.com/apache/polaris/pull/1515/files#r2074243975
   
   IMHO we should be consistent, as far as application.propeties is concerned we reference the quarkus conf page above so that audience can choose what ever way they prefer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "fabio-rizzo-01 (via GitHub)" <gi...@apache.org>.
fabio-rizzo-01 commented on PR #2706:
URL: https://github.com/apache/polaris/pull/2706#issuecomment-3359638498

   > @fabio-rizzo-01 : please rebase to fix CI
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #2706:
URL: https://github.com/apache/polaris/pull/2706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2388799872


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   I'd prefer to avoid options like env. vs. file in main docs. All of that is essentially a config entry. There are multiple sources for the config (env., system properties, properties file) and there are differences with how you can specific config names.
   
   Also, lower case names with dots do work in the environment (e.g. in docker/k8s) but do _not_ work in `bash` (and probably other shells).
   
   I think we may need to overhaul the docs WRT user-facing config, but let's keep the existing patterns for this PR (upper case env. variables).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2395738165


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   I guess that's right 😅 I think the PR is good to merge :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2388815677


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   Actually, the RDS config may not be easy to convert to upper case. So let's use lower case (with dots and dashes) in all cases. 
   
   Users have references to Quarkus docs and https://polaris.apache.org/in-dev/unreleased/configuration/
   
   I hope that should be enough input for them to figure out specifics in their deployment env.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "fabio-rizzo-01 (via GitHub)" <gi...@apache.org>.
fabio-rizzo-01 commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2393732164


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   so no changes needed from my side right? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updating metastore documentation with Aurora postgres example [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2706:
URL: https://github.com/apache/polaris/pull/2706#discussion_r2388799872


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -29,14 +29,45 @@ deprecated EclipseLink persistence backends.
 This implementation leverages Quarkus for datasource management and supports configuration through
 environment variables or JVM -D flags at startup. For more information, refer to the [Quarkus configuration reference](https://quarkus.io/guides/config-reference#env-file).
 
+We have 2 options for configuring the persistence backend:
 
+### 1. Relational JDBC metastore with username and password
+
+using environment variables:
 ```
 POLARIS_PERSISTENCE_TYPE=relational-jdbc
 
 QUARKUS_DATASOURCE_USERNAME=<your-username>
 QUARKUS_DATASOURCE_PASSWORD=<your-password>
 QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
 ```
+using properties file:
+
+```
+polaris.persistence.type=relational-jdbc
+quarkus.datasource.jdbc.username=<your-username>
+quarkus.datasource.jdbc.password=<your-password>
+quarkus.datasource.jdbc.jdbc-url=<jdbc-url-of-postgres>
+```

Review Comment:
   I'd prefer to avoid options like env. vs. file in main docs. All of that is essentially a config entry. There are multiple sources for the config (env., system properties, properties file) and there are differences with how you can specify config names.
   
   Also, lower case names with dots do work in the environment (e.g. in docker/k8s) but do _not_ work in `bash` (and probably other shells).
   
   I think we may need to overhaul the docs WRT user-facing config, but let's keep the existing patterns for this PR (upper case env. variables).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org