You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Alexey Petrenko (JIRA)" <ji...@apache.org> on 2006/03/02 11:55:43 UTC
[jira] Created: (HARMONY-152) Security module native build
incorrectly use PATH variable
Security module native build incorrectly use PATH variable
----------------------------------------------------------
Key: HARMONY-152
URL: http://issues.apache.org/jira/browse/HARMONY-152
Project: Harmony
Type: Bug
Components: Classlib
Environment: WinXP
Reporter: Alexey Petrenko
modules/security/make/build.xml, line 163
<property name="cPath" value="${PATH};${env.Path}" />
Should be probably changed to
<property name="cPath" value="${PATH};${env.PATH}" />
Since environment variables are case sensitive.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
using environment vars in Ant (was: Re: [jira] Created: (HARMONY-152)
Security module native build incorrectly use PATH variable)
Posted by Tim Ellison <t....@gmail.com>.
Matt Benson wrote:
> --- Alexey Petrenko <al...@gmail.com>
> wrote:
>
>> 2006/3/3, Tim Ellison <t....@gmail.com>:
>>> How about we just remove references to ENV from
>> the Ant scripts ;-) ?
>>> That sounds like a very strange 'feature' of Ant
>> Why not use environment if it needed and accessible?
>> Even in ant... :)
>
> Chiming in here to be sure there are no
> misunderstandings RE Ant's inclusion of environment
> variables... Your comment, Tim, sounds as though you
> thought ENV.* were automagically populated. In fact,
> you must explicitly request this in your buildfile
> [1], and it doesn't matter if you prefix them as ENV.*
> or foobarbaz.* ... :)
Yep, I got that
> Finally, a common workaround (which I would suggest
> using should this issue recur):
>
> <property environment="ENV" />
> <property name="ENV.PATH" value="${ENV.Path}" />
good idea.
> --if ENV.PATH already exists, it won't be overwritten.
> If ENV.Path exists, it follows that ENV.PATH does
> not, so the contents of ENV.Path will be assigned to
> ENV.PATH and with one line we have alleviated the W2K
> problem.
I'm kinda allergic to environment vars in build scripts anyways, I'd
much prefer that the scripts were standalone as far as possible.
> HTH,
> Matt
Thanks
Tim
> http://ant.apache.org/manual/CoreTasks/property.html
>
>> --
>> Alexey A. Petrenko
>> Intel Middleware Products Division
>>
>
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam? Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Matt Benson <gu...@yahoo.com>.
--- Alexey Petrenko <al...@gmail.com>
wrote:
> 2006/3/3, Tim Ellison <t....@gmail.com>:
> > How about we just remove references to ENV from
> the Ant scripts ;-) ?
> >
> > That sounds like a very strange 'feature' of Ant
> Why not use environment if it needed and accessible?
> Even in ant... :)
Chiming in here to be sure there are no
misunderstandings RE Ant's inclusion of environment
variables... Your comment, Tim, sounds as though you
thought ENV.* were automagically populated. In fact,
you must explicitly request this in your buildfile
[1], and it doesn't matter if you prefix them as ENV.*
or foobarbaz.* ... :)
Finally, a common workaround (which I would suggest
using should this issue recur):
<property environment="ENV" />
<property name="ENV.PATH" value="${ENV.Path}" />
--if ENV.PATH already exists, it won't be overwritten.
If ENV.Path exists, it follows that ENV.PATH does
not, so the contents of ENV.Path will be assigned to
ENV.PATH and with one line we have alleviated the W2K
problem.
HTH,
Matt
http://ant.apache.org/manual/CoreTasks/property.html
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Alexey Petrenko <al...@gmail.com>.
2006/3/3, Tim Ellison <t....@gmail.com>:
> How about we just remove references to ENV from the Ant scripts ;-) ?
>
> That sounds like a very strange 'feature' of Ant
Why not use environment if it needed and accessible?
Even in ant... :)
--
Alexey A. Petrenko
Intel Middleware Products Division
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly
use PATH variable
Posted by Tim Ellison <t....@gmail.com>.
How about we just remove references to ENV from the Ant scripts ;-) ?
That sounds like a very strange 'feature' of Ant
Regards,
Tim
Alexey Petrenko wrote:
>>>> see also http://ant.apache.org/manual/CoreTasks/property.html
>>> What part of this document you talking about?
>> "Note also that properties are case sensitive, even if the environment
>> variables on your operating system are not, e.g. it will be
>> ${env.Path} not ${env.PATH} on Windows 2000."
> Oops. Sorry. I've missed this sentence.
>
> Is it documented somewhere by MS? I'll try to find docs too.
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Alexey Petrenko <al...@gmail.com>.
> > > see also http://ant.apache.org/manual/CoreTasks/property.html
> > What part of this document you talking about?
> "Note also that properties are case sensitive, even if the environment
> variables on your operating system are not, e.g. it will be
> ${env.Path} not ${env.PATH} on Windows 2000."
Oops. Sorry. I've missed this sentence.
Is it documented somewhere by MS? I'll try to find docs too.
--
Alexey A. Petrenko
Intel Middleware Products Division
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/3/3, Alexey Petrenko <al...@gmail.com>:
> 2006/3/3, Mikhail Loenko <ml...@gmail.com>:
> > 'Path', 'Include', etc are common e.g. for Windows 2000,
> Really? Neve heard about this... Is it documented somewhere?
e.g. just follow the link I've sent
>
> > see also http://ant.apache.org/manual/CoreTasks/property.html
> What part of this document you talking about?
"Note also that properties are case sensitive, even if the environment
variables on your operating system are not, e.g. it will be
${env.Path} not ${env.PATH} on Windows 2000."
Thanks,
Mikhail
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Alexey Petrenko <al...@gmail.com>.
2006/3/3, Mikhail Loenko <ml...@gmail.com>:
> 'Path', 'Include', etc are common e.g. for Windows 2000,
Really? Neve heard about this... Is it documented somewhere?
> see also http://ant.apache.org/manual/CoreTasks/property.html
What part of this document you talking about?
--
Alexey A. Petrenko
Intel Middleware Products Division
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Mikhail Loenko <ml...@gmail.com>.
'Path', 'Include', etc are common e.g. for Windows 2000, see also
http://ant.apache.org/manual/CoreTasks/property.html
Well, I can fix *my* XP but a lot of people will download Harmony, try
and throw out
I think ALL common environment variables should be spelled all standard ways.
Thanks,
Mikhail
2006/3/2, Tim Ellison <t....@gmail.com>:
> I agree.
>
> Tim
>
> Alexey Petrenko wrote:
> > 2006/3/2, Mikhail Loenko <ml...@gmail.com>:
> >> They are really case sensitive, but e.g. on my XP the variable's name is
> >> 'Path'
> > Probably you should fix your XP in this case :)
> >
> > If we will treat PATH variable this way (use ALL the variants) then
> > why we will not use ALL variants of all other evironment variables?
> >
> > I think that PATH variable should be spelled as PATH without variants.
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly
use PATH variable
Posted by Tim Ellison <t....@gmail.com>.
I agree.
Tim
Alexey Petrenko wrote:
> 2006/3/2, Mikhail Loenko <ml...@gmail.com>:
>> They are really case sensitive, but e.g. on my XP the variable's name is
>> 'Path'
> Probably you should fix your XP in this case :)
>
> If we will treat PATH variable this way (use ALL the variants) then
> why we will not use ALL variants of all other evironment variables?
>
> I think that PATH variable should be spelled as PATH without variants.
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Alexey Petrenko <al...@gmail.com>.
2006/3/2, Mikhail Loenko <ml...@gmail.com>:
> They are really case sensitive, but e.g. on my XP the variable's name is
> 'Path'
Probably you should fix your XP in this case :)
If we will treat PATH variable this way (use ALL the variants) then
why we will not use ALL variants of all other evironment variables?
I think that PATH variable should be spelled as PATH without variants.
--
Alexey A. Petrenko
Intel Middleware Products Division
Re: [jira] Created: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Mikhail Loenko <ml...@gmail.com>.
They are really case sensitive, but e.g. on my XP the variable's name is
'Path'
I think it should include all various pathes, like Path, PATH, and path
and do not include PAth and PatH
Thanks,
Mikhail
2006/3/2, Alexey Petrenko (JIRA) <ji...@apache.org>:
> Security module native build incorrectly use PATH variable
> ----------------------------------------------------------
>
> Key: HARMONY-152
> URL: http://issues.apache.org/jira/browse/HARMONY-152
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: WinXP
> Reporter: Alexey Petrenko
>
>
> modules/security/make/build.xml, line 163
> <property name="cPath" value="${PATH};${env.Path}" />
>
> Should be probably changed to
> <property name="cPath" value="${PATH};${env.PATH}" />
>
> Since environment variables are case sensitive.
>
>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
Re: [jira] Resolved: (HARMONY-152) Security module native build incorrectly
use PATH variable
Posted by Tim Ellison <t....@gmail.com>.
Now that the auth natives have been moved into the native-src tree (as
discussed with Stepan), this line has disappeared from the build.xml anyway.
See http://svn.apache.org/viewcvs?rev=382441&view=rev
Regards,
Tim
Mikhail Loenko wrote:
> As I wrote in different thead it breaks the build on some Windows versions.
>
> And, beleive me, this is not the easiest failure to evaluate.
>
> I suggest roll back this fix
>
> Thanks,
> Mikhail
>
> 2006/3/2, Tim Ellison (JIRA) <ji...@apache.org>:
>> [ http://issues.apache.org/jira/browse/HARMONY-152?page=all ]
>>
>> Tim Ellison resolved HARMONY-152:
>> ---------------------------------
>>
>> Resolution: Fixed
>>
>> Alexey,
>>
>> Modified as you suggest to better support case sensitive env var platforms.
>> Fixed in SECURITY module make/build.xml at repo revision 382403.
>>
>> Please check this fix fully resolves your problem.
>>
>>
>>> Security module native build incorrectly use PATH variable
>>> ----------------------------------------------------------
>>>
>>> Key: HARMONY-152
>>> URL: http://issues.apache.org/jira/browse/HARMONY-152
>>> Project: Harmony
>>> Type: Bug
>>> Components: Classlib
>>> Environment: WinXP
>>> Reporter: Alexey Petrenko
>>> Assignee: Tim Ellison
>>> modules/security/make/build.xml, line 163
>>> <property name="cPath" value="${PATH};${env.Path}" />
>>> Should be probably changed to
>>> <property name="cPath" value="${PATH};${env.PATH}" />
>>> Since environment variables are case sensitive.
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the administrators:
>> http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Resolved: (HARMONY-152) Security module native build incorrectly use PATH variable
Posted by Mikhail Loenko <ml...@gmail.com>.
As I wrote in different thead it breaks the build on some Windows versions.
And, beleive me, this is not the easiest failure to evaluate.
I suggest roll back this fix
Thanks,
Mikhail
2006/3/2, Tim Ellison (JIRA) <ji...@apache.org>:
> [ http://issues.apache.org/jira/browse/HARMONY-152?page=all ]
>
> Tim Ellison resolved HARMONY-152:
> ---------------------------------
>
> Resolution: Fixed
>
> Alexey,
>
> Modified as you suggest to better support case sensitive env var platforms.
> Fixed in SECURITY module make/build.xml at repo revision 382403.
>
> Please check this fix fully resolves your problem.
>
>
> > Security module native build incorrectly use PATH variable
> > ----------------------------------------------------------
> >
> > Key: HARMONY-152
> > URL: http://issues.apache.org/jira/browse/HARMONY-152
> > Project: Harmony
> > Type: Bug
> > Components: Classlib
> > Environment: WinXP
> > Reporter: Alexey Petrenko
> > Assignee: Tim Ellison
>
> >
> > modules/security/make/build.xml, line 163
> > <property name="cPath" value="${PATH};${env.Path}" />
> > Should be probably changed to
> > <property name="cPath" value="${PATH};${env.PATH}" />
> > Since environment variables are case sensitive.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
[jira] Assigned: (HARMONY-152) Security module native build
incorrectly use PATH variable
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-152?page=all ]
Tim Ellison reassigned HARMONY-152:
-----------------------------------
Assign To: Tim Ellison
> Security module native build incorrectly use PATH variable
> ----------------------------------------------------------
>
> Key: HARMONY-152
> URL: http://issues.apache.org/jira/browse/HARMONY-152
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: WinXP
> Reporter: Alexey Petrenko
> Assignee: Tim Ellison
>
> modules/security/make/build.xml, line 163
> <property name="cPath" value="${PATH};${env.Path}" />
> Should be probably changed to
> <property name="cPath" value="${PATH};${env.PATH}" />
> Since environment variables are case sensitive.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-152) Security module native build
incorrectly use PATH variable
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-152?page=all ]
Tim Ellison resolved HARMONY-152:
---------------------------------
Resolution: Fixed
Alexey,
Modified as you suggest to better support case sensitive env var platforms.
Fixed in SECURITY module make/build.xml at repo revision 382403.
Please check this fix fully resolves your problem.
> Security module native build incorrectly use PATH variable
> ----------------------------------------------------------
>
> Key: HARMONY-152
> URL: http://issues.apache.org/jira/browse/HARMONY-152
> Project: Harmony
> Type: Bug
> Components: Classlib
> Environment: WinXP
> Reporter: Alexey Petrenko
> Assignee: Tim Ellison
>
> modules/security/make/build.xml, line 163
> <property name="cPath" value="${PATH};${env.Path}" />
> Should be probably changed to
> <property name="cPath" value="${PATH};${env.PATH}" />
> Since environment variables are case sensitive.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira