You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/02/13 23:10:46 UTC
[GitHub] [arrow] assignUser commented on a diff in pull request #34167: GH-34055: [Go][CI] Add test run in CI that uses noasm tag
assignUser commented on code in PR #34167:
URL: https://github.com/apache/arrow/pull/34167#discussion_r1105113975
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,40 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ noasm:
+ name: AMD64 Debian 11 Go ${{ matrix.go }} - NOASM
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ go: [1.17, 1.18]
+ include:
+ - go: 1.17
+ staticcheck: v0.2.2
+ - go: 1.18
+ staticcheck: v0.3.3
+ env:
+ GO: ${{ matrix.go }}
+ STATICCHECK: ${{ matrix.staticcheck }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install go
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ matrix.go }}
+ cache: true
+ cache-dependency-path: go/go.sum
+ - name: Install staticcheck
Review Comment:
Can we not run `go_test.sh` with the noasm flag in one of the exisisting jobs instead of creating another 2 jobs? The go matrix is pretty big already :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org