You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/10/28 06:50:45 UTC
[GitHub] [carbondata] niuge01 commented on a change in pull request #3421:
[CARBONDATA-3557] Support write Flink streaming data to Carbon
niuge01 commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon
URL: https://github.com/apache/carbondata/pull/3421#discussion_r339418531
##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -507,7 +509,7 @@ private void addTaskSummaryRowToUnsafeMemoryStore(CarbonRowSchema[] taskSummaryS
if (null != summaryRow) {
summaryRow.setByteArray(fileName, SUMMARY_INDEX_FILE_NAME);
summaryRow.setByteArray(segmentId, SUMMARY_SEGMENTID);
- if (null != filePath) {
+ if (filePath.length > 0) {
Review comment:
The filePath is can't be null, so we uncheck it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services