You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/03 19:34:47 UTC
Review Request: Added and used new Cluster abstraction for testing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10264/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/Makefile.am 0ef1eac19ff6f366e2590eed371958db8fd62289
src/tests/cluster.hpp PRE-CREATION
src/tests/isolator.hpp PRE-CREATION
src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
src/tests/state_tests.cpp 2661dcdf2e76de094591e97e9720f515ce3d0c8d
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
Diff: https://reviews.apache.org/r/10264/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added and used new Cluster abstraction for testing.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10264/#review18785
-----------------------------------------------------------
src/tests/cluster.hpp
<https://reviews.apache.org/r/10264/#comment39214>
It is already namespaced.. what are you referring to?
namespace utils {
template <typename T>
T copy(const T& t) { return t; }
} // namespace utils {
src/tests/cluster.hpp
<https://reviews.apache.org/r/10264/#comment39215>
Seems like a bug rather than a TODO.
- Ben Mahler
On April 3, 2013, 5:34 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10264/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 5:34 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 0ef1eac19ff6f366e2590eed371958db8fd62289
> src/tests/cluster.hpp PRE-CREATION
> src/tests/isolator.hpp PRE-CREATION
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/state_tests.cpp 2661dcdf2e76de094591e97e9720f515ce3d0c8d
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
>
> Diff: https://reviews.apache.org/r/10264/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>