[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1274: Fix license issues in rand.h, rocksdb_crc32c.h and batch_debugger.h

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #1274:
URL: https://github.com/apache/incubator-kvrocks/pull/1274#discussion_r1113777492


##########
NOTICE:
##########
@@ -223,11 +223,16 @@ It is under the MIT license with an optional exception:
     without including the above copyright and permission notices.
 
 For src/types/geohash.*, src/common/rand.*, src/common/sha1.*, src/storage/scripting.* and
-some functions in src/common/util.cc are modified from Redis.
+some functions in src/common/*_util.* are modified from Redis.
 
 We have added the Redis license notice in each file header, can also see bundled license file
 https://github.com/apache/incubator-kvrocks/blob/unstable/licenses/LICENSE.redis for details.
 
+For src/common/rocksdb_crc32c.* and src/storage/batch_debugger.* are modified from RocksDB.
+
+We have added the RocksDB license notice in each file header, can also see bundled license file
+https://github.com/apache/incubator-kvrocks/blob/unstable/licenses/LICENSE.rocksdb for details.

Review Comment:
   IIRC We don't have to duplicate ALv2 since the content is the same. But we do need to declare that we choose the ALv2 for RocksDB dependency since it's dual licensed by ALv2 and GPLv2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org