[GitHub] spark pull request: SPARK-2565. Update ShuffleReadMetrics as block...

[sryza <gi...@git.apache.org>]

Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1507#discussion_r15716773
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala ---
    @@ -73,11 +75,16 @@ class TaskMetrics extends Serializable {
       var inputMetrics: Option[InputMetrics] = None
     
       /**
    -   * If this task reads from shuffle output, metrics on getting shuffle data will be collected here
    +   * If this task reads from shuffle output, metrics on getting shuffle data will be collected here.
    +   * This includes read metrics aggregated over all the task's shuffle dependencies.
        */
    -  private var _shuffleReadMetrics: Option[ShuffleReadMetrics] = None
    +  var shuffleReadMetrics: Option[ShuffleReadMetrics] = None
    --- End diff --
    
    Making depsShuffleReadMetrics private.  shuffleReadMetrics still needs to be set inside of JsonProtocol, so making it private would either require updating it through createShuffleReadMetricsForDependency or adding a setter, both of which seem a little weird to me.  Any thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---