You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/02 14:25:05 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #13095: Allow to config Sasl configs in Kafka source
Shoothzj opened a new pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095
related to #11422
### Motivation
Allow pulsar io to consume messages to sasl kafka cluster.
### Modifications
Add several kafka sasl configs, make them configable.
### Documentation
Check the box below and label this PR (if you have committer privilege).
- [x] `no-need-doc`
**Pulsar-io** can automatically generate the doc for added fields. So we don't need add any docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985945838
@codelipenghui @hangc0276 @315157973 @michaeljmarshall PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985522982
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-993515026
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-993159111
@315157973 @nlu90 @Technoboy- PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-987940748
@nlu90 Would you please help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985522982
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#discussion_r768427724
##########
File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
##########
@@ -43,6 +43,49 @@
"A comma-separated list of host and port pairs that are the addresses of "
+ "the Kafka brokers that a Kafka client connects to initially bootstrap itself")
private String bootstrapServers;
+
+ @FieldDoc(
+ required = false,
+ defaultValue = "",
+ help = "Protocol used to communicate with kafka brokers.")
Review comment:
```suggestion
help = "Protocol used to communicate with Kafka brokers.")
```
Capitalize proper nouns correctly. Pls check all occurrences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985955916
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985945591
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13095: Allow to config Sasl configs in Kafka source
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13095:
URL: https://github.com/apache/pulsar/pull/13095#issuecomment-985955916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org