[GitHub] [rocketmq] 77yang commented on a change in pull request #1313: add missing log

[GitBox <gi...@apache.org>]

77yang commented on a change in pull request #1313: add missing log
URL: https://github.com/apache/rocketmq/pull/1313#discussion_r302489132
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
 ##########
 @@ -71,10 +71,9 @@ public static BrokerController start(BrokerController controller) {
             }
 
             log.info(tip);
-            System.out.printf("%s%n", tip);
             return controller;
         } catch (Throwable e) {
-            e.printStackTrace();
+            log.error("BrokerStartup fail to boot.", e);
 
 Review comment:
   @ShannonDing  The users will not know what happened when the program runs in the background if we use `e.printStackTrace();`  right?   And  I think it's a more standardized way of writing as an open source middleware. what do you think? 😀

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services