You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/02/11 20:52:22 UTC

[GitHub] [daffodil] stevedlawrence opened a new pull request #751: Modify the release candidate container to work for both daffodil and vscode

stevedlawrence opened a new pull request #751:
URL: https://github.com/apache/daffodil/pull/751


   - When running the release candidate script, prompt the user for either
     "daffodil" or "daffodil-vscode" to determine which repository to
     release. This changes which repo is checked out, how the repo is
     built, and which files are copied to the dist directory. All other
     automated build steps are common and are unchanged.
   - Daffodil release files are still installed to dist.apache.org/repos/dist/dev/daffodil/
   - VS Code release files are installed to dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode
   
   Also did some cleanup to the container script:
   
   - Move wix files and Docker setup/entrypoint scripts out of /root and
     into /opt and /usr/bin, respectively. With this change, the only files
     in /root are build files, making it easier to verify release artifacts
   - Add the --rm option to podman run. This container is short lived and
     does not need to exist once it finishes
   
   DAFFODIL-2655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence merged pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #751:
URL: https://github.com/apache/daffodil/pull/751


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1039181874


   Fair points. I don't feel strong about this and am fine with keeping it in here.
   
   Here's some additional thoughts in the back of my head, but which I don't think are all that strong of arguments since they're very future stuff and probably doesn't really apply right now:
   
   1. This is *almost* generic enough that it could be used for other apache projects. I sort of envision this repo growing to be a possible starting point for other projects to create their own release candidates. I know it was a pain to come up with all this stuff in the past, and it would be a shame for other new ASF projects to have to do something similar. That said, I doubt I'll want to do the work to make this truely generic. But if it were in a separate repo, others might.
   
   2. I could imagine a case where the daffodil repo is on some sort of code freeze but we want to make changes to the release candidate stuff for vscode (or maybe some other future project). By decoupling this release candidate container from any particular repo, it's easier to make those changes. That's not an issue now because we don't really code freeze, except maybe unofficially near releases, which aren't common.
   
   And maybe a potential argument against:
   
   1. It now requires a bit more effort to keep a third repo in sync. When building a release, we must ensure that the release manager uses the latest daffodil-relase-candidate repository or there might be subtle build issues. Theoretically either the build would fail, or it would be detected as part of the VOTE, so maybe not too big of a deal. But is another point of failure. That said, it's maybe not too different from our current method, where you should build from the latest Daffodil commit. For example, people that primarily do daffodil-vscode development have to clone the daffodil repo to do a release. Not a big deal, but might be a repo they don't always keep up to date.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] mbeckerle commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1039235826


   I am ok with leaving it in Daffodil's source tree for now. That works because these release scripts/containers aren't actually part of a release. They're not distributed. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
tuxji commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1039134519


   I don't think a separate repo makes sense (`apache/daffodil-release-candidate`).  I have 3 reasons: 1) we're talking about moving only 5 files which hardly justifies a separate repo at the Apache organization level; 2) the path `daffodil/containers/release-candidate` is much easier to understand than the repo name `daffodil-release-candidate`; 3) newcomers will feel more confused and waste more time trying to understand 3 daffodil-* repos than only 1 to 2 daffodil repos.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1039060935


   Once this change is committed, this container will not really be specific to daffodil anymore. I wonder if it makes sense to move the container directory to its own repository (e.g. `apache/daffodil-release-candidate`)? That way, if we ever need to make changes to the container for the vscode repo we don't have to make changes to this somewhat unrelated repo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1042122806


   This still needs another +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji commented on a change in pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
tuxji commented on a change in pull request #751:
URL: https://github.com/apache/daffodil/pull/751#discussion_r805040808



##########
File path: containers/release-candidate/daffodil-release-candidate
##########
@@ -183,52 +212,81 @@ DAFFODIL_TUTORIALS_DIR=$DAFFODIL_SITE_DIR/site/tutorials
 DAFFODIL_DIST_DIR=$REPO_ROOT/$DAFFODIL_DIST
 DAFFODIL_RELEASE_DIR=$DAFFODIL_DIST_DIR/$VERSION-$PRE_RELEASE
 
-if [ -d "$DAFFODIL_RELEASE_DIR" ]; then echo -e "\n!!! Daffodil release directory already exists: $DAFFODIL_RELEASE_DIR !!! "; exit; fi
+if [ -d "$DAFFODIL_RELEASE_DIR" ]; then echo -e "\n!!! $PROJECT_NAME release directory already exists: $DAFFODIL_RELEASE_DIR !!! "; exit; fi
 
 git -C $DAFFODIL_CODE_DIR config --local user.name  "$GIT_COMMIT_NAME"
 git -C $DAFFODIL_CODE_DIR config --local user.email "$GIT_COMMIT_EMAIL"
 git -C $DAFFODIL_SITE_DIR config --local user.name  "$GIT_COMMIT_NAME"
 git -C $DAFFODIL_SITE_DIR config --local user.email "$GIT_COMMIT_EMAIL"
 
 echo
-echo "!!! Making release $VERSION-$PRE_RELEASE in $DAFFODIL_RELEASE_DIR !!!"
+echo "!!! Creating $PROJECT_NAME $VERSION-$PRE_RELEASE in $DAFFODIL_RELEASE_DIR !!!"
 echo
 
-if [ "$DRY_RUN" = true ]; then
-  SBT_PUBLISH="publishLocalSigned"
-else
-  SBT_PUBLISH="publishSigned"
-fi
-
-echo "Building Convenience Binaries and Publishing to Apache Repository..."
-sbt \
-  "set ThisBuild/updateOptions := updateOptions.value.withGigahorse(false)" \
-  "set ThisBuild/credentials += Credentials(\"Sonatype Nexus Repository Manager\", \"repository.apache.org\", \"$APACHE_USERNAME\", \"$APACHE_PASSWD\")" \
-  "set ThisBuild/publishTo := Some(\"Apache Staging Distribution Repository\" at \"https://repository.apache.org/service/local/staging/deploy/maven2\")" \
-  "set pgpSigningKey := Some(\"$PGP_SIGNING_KEY_ID\")" \
-  "+compile" \
-  "+$SBT_PUBLISH" \
-  "daffodil-cli/Rpm/packageBin" \
-  "daffodil-cli/Windows/packageBin" \
-  "daffodil-cli/Universal/packageBin" \
-  "daffodil-cli/Universal/packageZipTarball" \
-  "unidoc" \
-
 echo "Removing old release candidates..."
 find $DAFFODIL_DIST_DIR -maxdepth 1 -name $VERSION-\* -exec svn delete --force {} \;
 
-echo "Installing Source and Convenience Binaries..."
-mkdir -p $DAFFODIL_RELEASE_DIR/{src,bin}/
-git archive --format=zip --prefix=apache-daffodil-$VERSION-src/ HEAD > $DAFFODIL_RELEASE_DIR/src/apache-daffodil-$VERSION-src.zip
-cp daffodil-cli/target/universal/apache-daffodil-*.tgz $DAFFODIL_RELEASE_DIR/bin/
-cp daffodil-cli/target/universal/apache-daffodil-*.zip $DAFFODIL_RELEASE_DIR/bin/
-cp daffodil-cli/target/rpm/RPMS/noarch/apache-daffodil-*.rpm $DAFFODIL_RELEASE_DIR/bin/
-MSI_NAME=$(basename $DAFFODIL_RELEASE_DIR/bin/*.zip .zip).msi
-cp daffodil-cli/target/windows/Daffodil.msi $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
-chmod -x $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+echo "Installing Source..."
+mkdir -p $DAFFODIL_RELEASE_DIR/src/
+git archive --format=zip --prefix=apache-$PROJECT_REPO-$VERSION-src/ HEAD > $DAFFODIL_RELEASE_DIR/src/apache-$PROJECT_REPO-$VERSION-src.zip
+
+case $PROJECT_REPO in
+  "daffodil")
+    if [ "$DRY_RUN" = true ]; then
+      SBT_PUBLISH="publishLocalSigned"
+    else
+      SBT_PUBLISH="publishSigned"
+    fi
+
+    echo "Building Convenience Binaries and Publishing to Apache Repository..."
+    sbt \
+      "set ThisBuild/updateOptions := updateOptions.value.withGigahorse(false)" \
+      "set ThisBuild/credentials += Credentials(\"Sonatype Nexus Repository Manager\", \"repository.apache.org\", \"$APACHE_USERNAME\", \"$APACHE_PASSWD\")" \
+      "set ThisBuild/publishTo := Some(\"Apache Staging Distribution Repository\" at \"https://repository.apache.org/service/local/staging/deploy/maven2\")" \
+      "set pgpSigningKey := Some(\"$PGP_SIGNING_KEY_ID\")" \
+      "+compile" \
+      "+$SBT_PUBLISH" \
+      "daffodil-cli/Rpm/packageBin" \
+      "daffodil-cli/Windows/packageBin" \
+      "daffodil-cli/Universal/packageBin" \
+      "daffodil-cli/Universal/packageZipTarball" \
+      "unidoc" \
+
+    echo "Installing Convenience Binaries..."
+    mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/universal/apache-daffodil-*.tgz $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/universal/apache-daffodil-*.zip $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/rpm/RPMS/noarch/apache-daffodil-*.rpm $DAFFODIL_RELEASE_DIR/bin/
+    MSI_NAME=$(basename $DAFFODIL_RELEASE_DIR/bin/*.zip .zip).msi
+    cp daffodil-cli/target/windows/Daffodil.msi $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+    chmod -x $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+
+    echo "Embedding RPM Signature..."
+    rpmsign --define "_gpg_name $PGP_SIGNING_KEY_ID" --define "_binary_filedigest_algorithm 10" --addsign $DAFFODIL_RELEASE_DIR/bin/*.rpm
+
+    echo "Installing Site Docs..."
+    rm -rf $DAFFODIL_DOCS_DIR
+    mkdir -p $DAFFODIL_DOCS_DIR/{javadoc,scaladoc}/
+    cp -R target/javaunidoc/* $DAFFODIL_DOCS_DIR/javadoc/
+    cp -R target/scala-2.12/unidoc/* $DAFFODIL_DOCS_DIR/scaladoc/
+
+    echo "Installing Site Tutorials..."
+    rm -rf $DAFFODIL_TUTORIALS_DIR
+    mkdir -p $DAFFODIL_TUTORIALS_DIR
+    cp -R tutorials/src/main/resources/* $DAFFODIL_TUTORIALS_DIR
+
+    ;;
+
+  "daffodil-vscode")
 
-echo "Embedding RPM Signature..."
-rpmsign --define "_gpg_name $PGP_SIGNING_KEY_ID" --define "_binary_filedigest_algorithm 10" --addsign $DAFFODIL_RELEASE_DIR/bin/*.rpm
+    echo "Building Convenience Binaries..."
+    mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+    yarn build
+    cp daffodil-debugger-*.vsix $DAFFODIL_RELEASE_DIR/bin/

Review comment:
       Can do the rename to apache-daffodil-vscode-VERSION.vsix (as suggested in [#83](https://github.com/apache/daffodil-vscode/issues/83)) only here, or also modify the yarn build to produce the renamed binary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] mbeckerle commented on pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #751:
URL: https://github.com/apache/daffodil/pull/751#issuecomment-1039235826


   I am ok with leaving it in Daffodil's source tree for now. That works because these release scripts/containers aren't actually part of a release. They're not distributed. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on a change in pull request #751: Modify the release candidate container to work for both daffodil and vscode

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #751:
URL: https://github.com/apache/daffodil/pull/751#discussion_r805805682



##########
File path: containers/release-candidate/daffodil-release-candidate
##########
@@ -183,52 +212,81 @@ DAFFODIL_TUTORIALS_DIR=$DAFFODIL_SITE_DIR/site/tutorials
 DAFFODIL_DIST_DIR=$REPO_ROOT/$DAFFODIL_DIST
 DAFFODIL_RELEASE_DIR=$DAFFODIL_DIST_DIR/$VERSION-$PRE_RELEASE
 
-if [ -d "$DAFFODIL_RELEASE_DIR" ]; then echo -e "\n!!! Daffodil release directory already exists: $DAFFODIL_RELEASE_DIR !!! "; exit; fi
+if [ -d "$DAFFODIL_RELEASE_DIR" ]; then echo -e "\n!!! $PROJECT_NAME release directory already exists: $DAFFODIL_RELEASE_DIR !!! "; exit; fi
 
 git -C $DAFFODIL_CODE_DIR config --local user.name  "$GIT_COMMIT_NAME"
 git -C $DAFFODIL_CODE_DIR config --local user.email "$GIT_COMMIT_EMAIL"
 git -C $DAFFODIL_SITE_DIR config --local user.name  "$GIT_COMMIT_NAME"
 git -C $DAFFODIL_SITE_DIR config --local user.email "$GIT_COMMIT_EMAIL"
 
 echo
-echo "!!! Making release $VERSION-$PRE_RELEASE in $DAFFODIL_RELEASE_DIR !!!"
+echo "!!! Creating $PROJECT_NAME $VERSION-$PRE_RELEASE in $DAFFODIL_RELEASE_DIR !!!"
 echo
 
-if [ "$DRY_RUN" = true ]; then
-  SBT_PUBLISH="publishLocalSigned"
-else
-  SBT_PUBLISH="publishSigned"
-fi
-
-echo "Building Convenience Binaries and Publishing to Apache Repository..."
-sbt \
-  "set ThisBuild/updateOptions := updateOptions.value.withGigahorse(false)" \
-  "set ThisBuild/credentials += Credentials(\"Sonatype Nexus Repository Manager\", \"repository.apache.org\", \"$APACHE_USERNAME\", \"$APACHE_PASSWD\")" \
-  "set ThisBuild/publishTo := Some(\"Apache Staging Distribution Repository\" at \"https://repository.apache.org/service/local/staging/deploy/maven2\")" \
-  "set pgpSigningKey := Some(\"$PGP_SIGNING_KEY_ID\")" \
-  "+compile" \
-  "+$SBT_PUBLISH" \
-  "daffodil-cli/Rpm/packageBin" \
-  "daffodil-cli/Windows/packageBin" \
-  "daffodil-cli/Universal/packageBin" \
-  "daffodil-cli/Universal/packageZipTarball" \
-  "unidoc" \
-
 echo "Removing old release candidates..."
 find $DAFFODIL_DIST_DIR -maxdepth 1 -name $VERSION-\* -exec svn delete --force {} \;
 
-echo "Installing Source and Convenience Binaries..."
-mkdir -p $DAFFODIL_RELEASE_DIR/{src,bin}/
-git archive --format=zip --prefix=apache-daffodil-$VERSION-src/ HEAD > $DAFFODIL_RELEASE_DIR/src/apache-daffodil-$VERSION-src.zip
-cp daffodil-cli/target/universal/apache-daffodil-*.tgz $DAFFODIL_RELEASE_DIR/bin/
-cp daffodil-cli/target/universal/apache-daffodil-*.zip $DAFFODIL_RELEASE_DIR/bin/
-cp daffodil-cli/target/rpm/RPMS/noarch/apache-daffodil-*.rpm $DAFFODIL_RELEASE_DIR/bin/
-MSI_NAME=$(basename $DAFFODIL_RELEASE_DIR/bin/*.zip .zip).msi
-cp daffodil-cli/target/windows/Daffodil.msi $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
-chmod -x $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+echo "Installing Source..."
+mkdir -p $DAFFODIL_RELEASE_DIR/src/
+git archive --format=zip --prefix=apache-$PROJECT_REPO-$VERSION-src/ HEAD > $DAFFODIL_RELEASE_DIR/src/apache-$PROJECT_REPO-$VERSION-src.zip
+
+case $PROJECT_REPO in
+  "daffodil")
+    if [ "$DRY_RUN" = true ]; then
+      SBT_PUBLISH="publishLocalSigned"
+    else
+      SBT_PUBLISH="publishSigned"
+    fi
+
+    echo "Building Convenience Binaries and Publishing to Apache Repository..."
+    sbt \
+      "set ThisBuild/updateOptions := updateOptions.value.withGigahorse(false)" \
+      "set ThisBuild/credentials += Credentials(\"Sonatype Nexus Repository Manager\", \"repository.apache.org\", \"$APACHE_USERNAME\", \"$APACHE_PASSWD\")" \
+      "set ThisBuild/publishTo := Some(\"Apache Staging Distribution Repository\" at \"https://repository.apache.org/service/local/staging/deploy/maven2\")" \
+      "set pgpSigningKey := Some(\"$PGP_SIGNING_KEY_ID\")" \
+      "+compile" \
+      "+$SBT_PUBLISH" \
+      "daffodil-cli/Rpm/packageBin" \
+      "daffodil-cli/Windows/packageBin" \
+      "daffodil-cli/Universal/packageBin" \
+      "daffodil-cli/Universal/packageZipTarball" \
+      "unidoc" \
+
+    echo "Installing Convenience Binaries..."
+    mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/universal/apache-daffodil-*.tgz $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/universal/apache-daffodil-*.zip $DAFFODIL_RELEASE_DIR/bin/
+    cp daffodil-cli/target/rpm/RPMS/noarch/apache-daffodil-*.rpm $DAFFODIL_RELEASE_DIR/bin/
+    MSI_NAME=$(basename $DAFFODIL_RELEASE_DIR/bin/*.zip .zip).msi
+    cp daffodil-cli/target/windows/Daffodil.msi $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+    chmod -x $DAFFODIL_RELEASE_DIR/bin/$MSI_NAME
+
+    echo "Embedding RPM Signature..."
+    rpmsign --define "_gpg_name $PGP_SIGNING_KEY_ID" --define "_binary_filedigest_algorithm 10" --addsign $DAFFODIL_RELEASE_DIR/bin/*.rpm
+
+    echo "Installing Site Docs..."
+    rm -rf $DAFFODIL_DOCS_DIR
+    mkdir -p $DAFFODIL_DOCS_DIR/{javadoc,scaladoc}/
+    cp -R target/javaunidoc/* $DAFFODIL_DOCS_DIR/javadoc/
+    cp -R target/scala-2.12/unidoc/* $DAFFODIL_DOCS_DIR/scaladoc/
+
+    echo "Installing Site Tutorials..."
+    rm -rf $DAFFODIL_TUTORIALS_DIR
+    mkdir -p $DAFFODIL_TUTORIALS_DIR
+    cp -R tutorials/src/main/resources/* $DAFFODIL_TUTORIALS_DIR
+
+    ;;
+
+  "daffodil-vscode")
 
-echo "Embedding RPM Signature..."
-rpmsign --define "_gpg_name $PGP_SIGNING_KEY_ID" --define "_binary_filedigest_algorithm 10" --addsign $DAFFODIL_RELEASE_DIR/bin/*.rpm
+    echo "Building Convenience Binaries..."
+    mkdir -p $DAFFODIL_RELEASE_DIR/bin/
+    yarn build
+    cp daffodil-debugger-*.vsix $DAFFODIL_RELEASE_DIR/bin/

Review comment:
       I forgot about the potential rename.
   
   I'd rather not rename it here if it can be done in the vscode repo. I could imagine the original name of 'daffodil-debugger' might show up some where and confuse users if the original file they actually installed was something else (like the suggested apache-daffodil-vsocde name).
   
   But I think I'll change this to `cp *.vsix $DAFFODIL_RELEASE_DIR/bin/`. There should only ever be one .vsix file so no issues with globbing too much, and this allows it to be named whatever the project thinks makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org