[GitHub] [tvm] areusch commented on a diff in pull request #12390: [MicroTVM] add heap-size to project options

[GitBox <gi...@apache.org>]

areusch commented on code in PR #12390:
URL: https://github.com/apache/tvm/pull/12390#discussion_r951717731


##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -370,6 +397,12 @@ def _get_nrf_device_args(options):
         type="bool",
         help="Run on the FVP emulator instead of hardware.",
     ),
+    server.ProjectOption(
+        "heap_size",

Review Comment:
   nit: heap_size_bytes



##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -370,6 +397,12 @@ def _get_nrf_device_args(options):
         type="bool",
         help="Run on the FVP emulator instead of hardware.",
     ),
+    server.ProjectOption(
+        "heap_size",
+        optional=["generate_project"],
+        type="int",
+        help="Sets HEAP_SIZE for Zephyr board.",

Review Comment:
   since HEAP_SIZE isn't a Zephyr option, can you instead say something more like "Sets the size of the heap used to service TVM memory allocation requests"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org