You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (JIRA)" <ji...@apache.org> on 2019/07/24 03:23:00 UTC
[jira] [Commented] (FLINK-13391) Blink-planner should not invoke
deprecated getReturnType of TableSource
[ https://issues.apache.org/jira/browse/FLINK-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891562#comment-16891562 ]
Jark Wu commented on FLINK-13391:
---------------------------------
I think we should not call {{getReturnType}} in {{InputFormatTableSource#getDataStream}}. We should call {{TypeConversions.fromDataTypeToLegacyInfo(getProducedDataType())}} instead.
> Blink-planner should not invoke deprecated getReturnType of TableSource
> -----------------------------------------------------------------------
>
> Key: FLINK-13391
> URL: https://issues.apache.org/jira/browse/FLINK-13391
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: Jingsong Lee
> Priority: Major
> Fix For: 1.9.0, 1.10.0
>
>
> Now, blink-planner will invoke getDataStream of InputFormatTableSource, this will invoke deprecated getReturnType method.
> We should invoke getInputFormat of InputFormatTableSource to be same as flink-planner.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)