[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs

[GitBox <gi...@apache.org>]

kgabryje edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-718008571


   @ktmud I'm having some troubles with implementing what you proposed. If the pasted value contains both incorrect and correct metric names, let's say `gender, test1, ds, test2`, gender and ds metric options are created correctly, but then the input loses focus due to re-render and it's cleared. So the actual result is that we created options `gender` and `ds` and discarded other values. Also, I'm not sure how to handle auto-openning popups when more than 1 option is created.
   Do you have any idea for a workaround?
   
   Another case is when there's more than 1 incorrect text - I think that when user pastes `test1, test2, test3` (comma is a separator), we should actually paste either the first or the last item so that we can display dropdown with suggestions. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org