You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Brian Lawler <bl...@branuity.com> on 2002/04/17 21:06:25 UTC

[PATCH] UUIdGenerator and BaseValueParser...

Hello Turbine Developers-

I am currently trying to transition over to the turbine-2 head in my development environment and have come across 2 things that I end up having to change in the code whenever I go to a new release.

1) UUIdGenerator tries to parse a mac address from the TR.props file byte by byte using Byte.parseByte(str, radix).  This works fine if str is -7F thru 7F.  However, for values between 80 and FF there is a number format exception.  I have included a simple patch that fixes this.

2) In BaseValueParser, setProperty() is private.  I have an extension of this class that needs to overide this method and do some extra processing.  Is there any reason not to change this method to protected?  If not, patch is enclosed.

Thanks to all of you guys for all of the hard work and dedication.  I have been using turbine for several months now and have had great success with it.

-- 
Brian Lawler

Re: [PATCH] UUIdGenerator and BaseValueParser...

Posted by John McNally <jm...@collab.net>.
Both patches have been applied.

thanks,
john mcnally

On Wed, 2002-04-17 at 12:06, Brian Lawler wrote:
> Hello Turbine Developers-
> 
> I am currently trying to transition over to the turbine-2 head in my development environment and have come across 2 things that I end up having to change in the code whenever I go to a new release.
> 
> 1) UUIdGenerator tries to parse a mac address from the TR.props file byte by byte using Byte.parseByte(str, radix).  This works fine if str is -7F thru 7F.  However, for values between 80 and FF there is a number format exception.  I have included a simple patch that fixes this.
> 
> 2) In BaseValueParser, setProperty() is private.  I have an extension of this class that needs to overide this method and do some extra processing.  Is there any reason not to change this method to protected?  If not, patch is enclosed.
> 
> Thanks to all of you guys for all of the hard work and dedication.  I have been using turbine for several months now and have had great success with it.
> 
> -- 
> Brian Lawler
> 
> ----
> 

> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>