You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhoujinsong (via GitHub)" <gi...@apache.org> on 2024/07/04 08:41:03 UTC
Re: [PR] [AMORO-2993] Enrich optimizing metrics [amoro]
zhoujinsong commented on code in PR #2994:
URL: https://github.com/apache/amoro/pull/2994#discussion_r1665354757
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/table/TableOptimizingMetrics.java:
##########
@@ -163,6 +165,37 @@ public class TableOptimizingMetrics {
.withTags("catalog", "database", "table")
.build();
+ public static final MetricDefine TABLE_LAST_MINOR_OPTIMIZING_INTERVAL =
+ defineGauge("table_last_minor_optimizing_duration_mills")
+ .withDescription("Duration in milliseconds after last minor optimizing")
+ .withTags("catalog", "database", "table")
+ .build();
+
+ public static final MetricDefine TABLE_LAST_MAJOR_OPTIMIZING_INTERVAL =
+ defineGauge("table_last_major_optimizing_duration_mills")
+ .withDescription("Duration in milliseconds after last major optimizing")
+ .withTags("catalog", "database", "table")
+ .build();
+
+ public static final MetricDefine TABLE_LAST_FULL_OPTIMIZING_DURATION =
+ defineGauge("table_last_full_optimizing_duration_mills")
+ .withDescription("Duration in milliseconds after last full optimizing")
+ .withTags("catalog", "database", "table")
+ .build();
+
+ public static final MetricDefine TABLE_LAST_OPTIMIZING_DURATION =
+ defineGauge("table_last_optimizing_duration_mills")
+ .withDescription("Duration in milliseconds after last optimizing")
+ .withTags("catalog", "database", "table")
+ .build();
+
+ public static final MetricDefine TABLE_OPTIMIZING_REFRESHED_SNAPSHOT_SLIDE_INTERVAL =
Review Comment:
Is `table_optimizing_lag_duration_mills` a proper name?
And we should calculate it with: latestSnapshot.time - optimizedSnapshot.time.
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/table/TableOptimizingMetrics.java:
##########
@@ -163,6 +165,37 @@ public class TableOptimizingMetrics {
.withTags("catalog", "database", "table")
.build();
+ public static final MetricDefine TABLE_LAST_MINOR_OPTIMIZING_INTERVAL =
+ defineGauge("table_last_minor_optimizing_duration_mills")
Review Comment:
Considering that the metrics related to optimizing on the table are currently prefixed with `table_optimizing`, I suggest renaming this monitoring metric to `table_optimizing_minor_time_mills_since_last_completion` or `table_optimizing_minor_duration_mills_since_last_completion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org