You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/12/07 21:35:06 UTC
svn commit: r1848423 -
/tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
Author: markt
Date: Fri Dec 7 21:35:05 2018
New Revision: 1848423
URL: http://svn.apache.org/viewvc?rev=1848423&view=rev
Log:
Increase wait time to 10ms after observing some Buildbot runs take ~5ms. 10ms may be too high but it is still low enough to be sure the non-blocking functionality is working.
Modified:
tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
Modified: tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java?rev=1848423&r1=1848422&r2=1848423&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java Fri Dec 7 21:35:05 2018
@@ -195,8 +195,8 @@ public class TestSocketServer extends Ab
}
long wait = System.nanoTime() - start;
Assert.assertTrue("Timeout failed", ok);
- Assert.assertFalse("non_blocking accept Socket.APR_SO_NONBLOCK failed (>1ms) [" + wait +
- "] +-[" + ERROR_MARGIN + "]", wait > 1000000 + ERROR_MARGIN);
+ Assert.assertFalse("non_blocking accept Socket.APR_SO_NONBLOCK failed (>10ms) [" + wait +
+ "] +-[" + ERROR_MARGIN + "]", wait > 10000000 + ERROR_MARGIN);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1848423 -
/tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
Posted by Mark Thomas <ma...@apache.org>.
On 07/12/2018 21:35, markt@apache.org wrote:
> Author: markt
> Date: Fri Dec 7 21:35:05 2018
> New Revision: 1848423
>
> URL: http://svn.apache.org/viewvc?rev=1848423&view=rev
> Log:
> Increase wait time to 10ms after observing some Buildbot runs take ~5ms. 10ms may be too high but it is still low enough to be sure the non-blocking functionality is working.
For the record, the failures of this test I observed on Windows has the
same root cause. The time for the call to return varied from 1.5ms to
48ms (no that isn't a typo).
I'm not planning on raising this threshold further at the moment but I
do want to keep an eye on it to see what the failure rate is like with a
limit of 10ms.
Mark
>
> Modified:
> tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
>
> Modified: tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java?rev=1848423&r1=1848422&r2=1848423&view=diff
> ==============================================================================
> --- tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java (original)
> +++ tomcat/trunk/test/org/apache/tomcat/jni/TestSocketServer.java Fri Dec 7 21:35:05 2018
> @@ -195,8 +195,8 @@ public class TestSocketServer extends Ab
> }
> long wait = System.nanoTime() - start;
> Assert.assertTrue("Timeout failed", ok);
> - Assert.assertFalse("non_blocking accept Socket.APR_SO_NONBLOCK failed (>1ms) [" + wait +
> - "] +-[" + ERROR_MARGIN + "]", wait > 1000000 + ERROR_MARGIN);
> + Assert.assertFalse("non_blocking accept Socket.APR_SO_NONBLOCK failed (>10ms) [" + wait +
> + "] +-[" + ERROR_MARGIN + "]", wait > 10000000 + ERROR_MARGIN);
> }
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org