[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python

[GitBox <gi...@apache.org>]

vkagamlyk commented on code in PR #1676:
URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889226039


##########
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV1.py:
##########
@@ -255,15 +257,15 @@ class LongIO(_GraphBinaryTypeIO):
     @classmethod
     def dictify(cls, obj, writer, to_extend, as_value=False, nullable=True):
         if obj < -9223372036854775808 or obj > 9223372036854775807:
-            raise Exception("TODO: don't forget bigint")
+            raise Exception("Value too big, please use bigint Gremlin type")

Review Comment:
   implicit conversion can introduce new issues, for example 
   `g.inject(1).repeat(__.addV('person').property('name', __.loops())).times(9223372036854775807 + 1).count()`
   
   leads to server exception
   `[ERROR] TraversalOpProcessor - Could not deserialize the Traversal instance
   java.lang.IllegalStateException: null: .times(BigInteger)`
   
   if you think that this is not an issue, then I will add implicit conversion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org