[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #20683: [improve][admin] Remove duplicate topics name when `deleteNamespace`

["lifepuzzlefun (via GitHub)" <gi...@apache.org>]

lifepuzzlefun commented on code in PR #20683:
URL: https://github.com/apache/pulsar/pull/20683#discussion_r1248562526


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -279,6 +279,12 @@ private void internalRetryableDeleteNamespaceAsync0(boolean force, int retryTime
                                         return old;
                                     });
                                 }
+                                allUserCreatedTopics.removeIf(t ->

Review Comment:
   maybe we can use Set here. removeIf in List seems may cause more CPU.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org