You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by sm...@apache.org on 2015/05/22 15:52:03 UTC

directory-fortress-core git commit: FC-105 - [fortress-core] - String.indexOf(char) is faster than String.indexOf(String)

Repository: directory-fortress-core
Updated Branches:
  refs/heads/master 713cde73a -> 746cbacb5


FC-105 - [fortress-core] - String.indexOf(char) is faster than String.indexOf(String)


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/746cbacb
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/746cbacb
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/746cbacb

Branch: refs/heads/master
Commit: 746cbacb5ab9d4209b8b48cc2dc3b491069fe128
Parents: 713cde7
Author: Shawn McKinney <sm...@apache.org>
Authored: Fri May 22 08:52:00 2015 -0500
Committer: Shawn McKinney <sm...@apache.org>
Committed: Fri May 22 08:52:00 2015 -0500

----------------------------------------------------------------------
 .../directory/fortress/core/rbac/AdminRole.java  | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/746cbacb/src/main/java/org/apache/directory/fortress/core/rbac/AdminRole.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/AdminRole.java b/src/main/java/org/apache/directory/fortress/core/rbac/AdminRole.java
index 5580676..761a1fb 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/AdminRole.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/AdminRole.java
@@ -229,27 +229,27 @@ public class AdminRole extends Role implements Administrator
     {
         if ( VUtil.isNotNullOrEmpty( szRaw ) )
         {
-            int bindx = szRaw.indexOf( "(" );
+            int bindx = szRaw.indexOf( '(' );
             if ( bindx > -1 )
             {
                 this.setBeginInclusive( false );
             }
             else
             {
-                bindx = szRaw.indexOf( "[" );
+                bindx = szRaw.indexOf( '[' );
                 this.setBeginInclusive( true );
             }
-            int eindx = szRaw.indexOf( ")" );
+            int eindx = szRaw.indexOf( ')' );
             if ( eindx > -1 )
             {
                 this.setEndInclusive( false );
             }
             else
             {
-                eindx = szRaw.indexOf( "]" );
+                eindx = szRaw.indexOf( ']' );
                 this.setEndInclusive( true );
             }
-            int cindx = szRaw.indexOf( ":" );
+            int cindx = szRaw.indexOf( ':' );
             if ( cindx > -1 )
             {
                 String szBeginRange = szRaw.substring( bindx + 1, cindx );
@@ -275,16 +275,25 @@ public class AdminRole extends Role implements Administrator
         if ( this.beginRange != null )
         {
             if ( this.isBeginInclusive() )
+            {
                 szRaw += "[";
+            }
             else
+            {
                 szRaw += "(";
+            }
             szRaw += this.getBeginRange();
             szRaw += ":";
             szRaw += this.getEndRange();
             if ( this.isEndInclusive() )
+            {
                 szRaw += "]";
+            }
             else
+            {
                 szRaw += ")";
+            }
+
         }
         return szRaw;
     }